feat(resource-detector-azure): add detector for Azure Container Apps #3289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Thompson <[email protected]>
Co-authored-by: James Thompson <[email protected]>
Co-authored-by: James Thompson <[email protected]>
Co-authored-by: James Thompson <[email protected]>
Contributor
|
@forsen can you update the implementation to match the changes to the readme? |
Author
| process.env = originalEnv; | ||
| }); | ||
|
|
||
| it('should detect Azure Container Apps resource attributes', () => { |
Contributor
There was a problem hiding this comment.
As all of our other resource detectors are designed to run alongside one another, it'd be good to add a test here to ensure that multiple resource detectors can be registered with no interference.
I trust isAzureContainerApps to keep this scoped correctly, but this would be good to have to detect any possible regressions in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR adds detector for Azure Container Apps.
Short description of the changes
Adds detector for Azure Container Apps, detecting the built-in environment variables:
https://learn.microsoft.com/en-us/azure/container-apps/environment-variables?tabs=portal#apps
Tried to use attributes from semconv where applicable, using custom ones otherwise.
I've not implemented functionality to fetch metadata from Azure metadata endpoint. I'm fairly new with Open Telemetry, so consider the attribute mapping as a suggestion only.