fix(instrumentation-web-exception): properly add bounded error listener #3322
+16
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The README.md advises to use the instrumentation like this:
But this does not work because the function passed to
addEventListener('error', ...)is the unbounded method, so accesses tothis.getConfig()fails.I know this sounds surprising, because the
onErrormethod was properly reaffected with the bounded method in the constructor. But actually,enable()is called by the base class, duringsuper(), which is called before theonErroris bound!This wasn't caught in tests because in test,
enable()is called two times, once when instantiating the instrumentation, and once explicitely when callinginstr.enable(). This second call do register the correctly bounded method.Short description of the changes
onErrormethod is proprely bound inenable().