Type-erase Quantity text conversion - #217
Draft
TurkeyMan wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quantitytext formatting into floating-point and integral backendsdoubleWhy
Quantity!(T, unit)previously instantiated the complete formatting, parsing, and dynamic scale-conversion machinery for each representation and unit. These are cold runtime operations and gain nothing from hard-unit specialization. Thin typed adapters now pass the value and unit into shared backends, while arithmetic between hard units remains specialized.An isolated SmartEVSE ESP32 release A/B build reduced the linked image by 416 bytes. That firmware emits only one Quantity formatter and three parsers, so targets using more Quantity text instantiations should gain more deduplication.
Validation
urt.si.quantitysuite passes, including hard-unit arithmetic, scaled integer round-trip,long.min, values beyond exactdoubleprecision, andulong.maxgit diff --checkpasses