Skip to content

[Fix #1685] Adding missing native classes - #1686

Merged
fjtirado merged 1 commit into
open-workflow-specification:mainfrom
fjtirado:Fix_#1685
Sep 18, 2026
Merged

fjtirado merged 1 commit into
open-workflow-specification:mainfrom
fjtirado:Fix_#1685

Conversation

@fjtirado

Copy link
Copy Markdown
Collaborator

Fix #1685

Copilot AI lite review requested due to automatic review settings September 17, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The required native-image reflection entries are present and no unresolved issues were identified.

Pull request overview

Adds missing GraalVM native-image reflection metadata for Jackson collection handlers.

Changes:

  • Registers JacksonModelCollectionSerializer.
  • Registers JacksonModelCollectionDeserializer.
File summaries
File Description
impl/model/src/main/resources/META-INF/native-image/io.serverlessworkflow/serverlessworkflow-impl-model/reflect-config.json Adds reflection configuration for collection serialization handlers.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@gmunozfe gmunozfe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Tested and that exception is gone. Well done @fjtirado

@fjtirado fjtirado changed the title [Fix #1685] Adding missing native classes https://github.com/open-workflow-specification/sdk-java/issues/1685 Sep 18, 2026
Fix open-workflow-specification#1685

Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
@fjtirado fjtirado changed the title https://github.com/open-workflow-specification/sdk-java/issues/1685 [Fix #1685] Adding missing native classes Sep 18, 2026
@fjtirado
fjtirado merged commit 1dbf6c9 into open-workflow-specification:main Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing for native JacksonModelCollectionSerializer and deserializer

3 participants