Repository navigation
Use Integer.compare at ServicePriority#compareTo - #1799
Merged
Merged
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change fixes comparator overflow while preserving the intended priority ordering, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes #1797 by making the shared service-priority comparator safe from integer overflow, ensuring WorkflowUtils.loadFirst selects implementations in the intended priority order.
Changes:
- Replaces subtraction with
Integer.compare, preserving ascending ordering across the full integer range.
| File | Description |
|---|---|
| impl/core/src/main/java/org/openworkflow/sdk/impl/ServicePriority.java | Uses overflow-safe comparison in compareTo. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):
Closes #1797