skip actor permission check for schedule (cron) triggers#73
Open
ikeisuke wants to merge 1 commit intoopenai:mainfrom
Open
skip actor permission check for schedule (cron) triggers#73ikeisuke wants to merge 1 commit intoopenai:mainfrom
ikeisuke wants to merge 1 commit intoopenai:mainfrom
Conversation
Scheduled workflows set GITHUB_ACTOR to the user who last modified the cron syntax in the workflow file, not a meaningful triggering user. Since only users with write access can modify workflow files, schedule events are implicitly authorized. This avoids spurious permission check failures on cron runs.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a workflow is triggered by
schedule, GitHub setsGITHUB_ACTORto the user who last modified the cron syntax — not the user who triggered the run. This can cause the permission check to fail unexpectedly.Since only users with write access can modify workflow files, schedule runs don't have a meaningful triggering actor. This PR passes
github.event_nameinto thecheck-write-accesscommand and skips the actor permission check for schedule events.Test plan
npm run buildsucceedsGITHUB_EVENT_NAME=scheduleskips the permission check with an info logpush,pull_request, etc.) behave as before