Repository navigation
refactor: delete the retired worker runtime - #1167
mldangelo-oai merged 2 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The retired runtime is removed cleanly with no remaining references, and the retained entrypoint uses an equivalent shared constant.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the retired coordinator worker runtime after Deep Scan execution moved to the SDK.
Changes:
- Deletes legacy worker execution, permission, sandbox, error, and type modules.
- Removes their dedicated tests.
- Reuses the shared native sandbox capability constant.
| File | Description |
|---|---|
tests/test_deep_scan_permission_profile_preflight.mjs |
Removes retired preflight tests. |
tests/test_deep_scan_parent_sandbox.mjs |
Removes retired sandbox tests. |
tests/test_deep_scan_executor.mjs |
Removes retired executor tests. |
src/deep-scan/worker-runner.ts |
Deletes the legacy worker runner. |
src/deep-scan/types.ts |
Deletes legacy runtime types. |
src/deep-scan/permission-profile-preflight.ts |
Deletes legacy permission preflight. |
src/deep-scan/parent-sandbox.ts |
Deletes legacy sandbox handling. |
src/deep-scan/executor.ts |
Deletes the legacy SDK executor. |
src/deep-scan/executable-path.ts |
Deletes obsolete executable handling. |
src/deep-scan/errors.ts |
Deletes obsolete runtime errors. |
artifact-writer-main.ts |
Imports the shared native permission constant. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
9379491 to
ebc31d5
Compare
7bf702a to
e2ac389
Compare
ebc31d5 to
459b3f1
Compare
021cc8a to
af45da2
Compare
459b3f1 to
0e7cbd9
Compare
faizan-oai
left a comment
faizan-oai
left a comment
There was a problem hiding this comment.
Reviewed the retired worker-runtime deletion at af45da2 and the remaining native execution imports. Integrated typechecking, plugin build, and native launch/stop checks pass. No new issue found in this cleanup increment.
0e7cbd9 to
e15d2c7
Compare
af45da2 to
de084ce
Compare
e15d2c7 to
9ddfa73
Compare
de084ce to
1e81818
Compare
alandelong-oai
left a comment
alandelong-oai
left a comment
There was a problem hiding this comment.
Three independent passes and root verification found no actionable regression in the worker runtime removals and artifact-writer import change. MCP type checking, the exact-head plugin build, and native permission checks passed. No repository files were changed.
1e81818 to
f03a222
Compare
alandelong-oai
left a comment
alandelong-oai
left a comment
There was a problem hiding this comment.
Three independent re-review passes and root reconciliation are complete for this restacked head.
No serious outstanding finding was identified in this change. The scoped prior review and current diff remain consistent.
Approval is for this change. Integrated-tip validation passed 1,357 SDK tests (31 skipped), 105 MCP tests (2 skipped), portable checks, types/builds and installed-package smoke. Other stack findings and known CI fixture failures still prevent the stack from being mergeable.
f03a222 to
4aee47e
Compare
282a073 to
062de44
Compare
There was a problem hiding this comment.
Re-reviewed the real PR diff at 4aee47e3a04497604beddee0df6a6e5f095aedc1. The patch is unchanged from the prior three-pass review. I reconciled the inherited changes in touched files and retained the prior verified findings and tests.
No serious outstanding finding identified in this patch; prior conclusions remain consistent with the unchanged change or the current re-review.
Validation across touched paths at branch tip 06e75cfe: 1,356 SDK tests, 867 Python tests plus 100 subtests, and 108 MCP tests passed; builds, types, portable checks and installed-package checks passed. These are integration checks at the branch tip, not a claim that every intermediate PR or its CI is clean. Latest workflow runs for this unchanged head were verified successful at 2026-10-02 01:26 UTC. Earlier failed or canceled job records are superseded; this CI status correction does not alter the review decision.
4aee47e to
c06099d
Compare
062de44 to
813fb2c
Compare
c06099d to
696c980
Compare
813fb2c to
32ffaf0
Compare
alandelong-oai
left a comment
alandelong-oai
left a comment
There was a problem hiding this comment.
Retained the three independent passes for the identical patch and reconciled inherited touched-file changes at 696c980fc7bf.
No actionable introduced finding survives the independent reviews and root reconciliation of this exact patch, touched-file changes, and current integration checks.
Current tip 355ec321 passed 75 report-projection tests, portable source checks, SDK build:ci and plugin build. The immediately preceding tip fec36f1d passed 1,360 SDK tests, 873 Python tests plus 100 subtests, 109 MCP tests, builds/types and the clean 600-entry installed-package check. Only report_projection.py and its test changed between those tips; SDK/MCP runtime files are byte-identical. Both descend from main 008a8b4d. These are integration checks, separate from own-head probes. No native Windows local run.
No serious outstanding finding introduced by this PR. Code review approval does not establish CI or merge readiness.
696c980 to
691b169
Compare
32ffaf0 to
0f32f2f
Compare
alandelong-oai
left a comment
alandelong-oai
left a comment
There was a problem hiding this comment.
Retained the three independent passes for the verified identical patch and reconciled inherited touched-file changes at 691b169e60a6.
No actionable introduced finding survives the independent reviews and root reconciliation of this exact patch and inherited changes in touched files.
Integrated tip 6ef8cbb8, based on 008a8b4d, passed 1,388 SDK tests, 879 Python tests plus 100 subtests, 109 MCP tests, portable checks, builds and the clean 600-entry installed-package check. These are branch-tip integration checks, separate from own-head probes; no local Windows execution was performed.
No serious outstanding finding introduced by this PR. Code approval is separate from CI and merge readiness.
0f32f2f to
5044341
Compare
691b169 to
304027a
Compare
alandelong-oai
left a comment
alandelong-oai
left a comment
There was a problem hiding this comment.
Retained three prior independent passes for the verified identical patch and reconciled inherited touched-file changes at 304027ac660b.
No actionable introduced finding survives the independent reviews and root reconciliation of this exact patch and inherited changes in touched files.
Branch tip 3e0083d9, based on 008a8b4d, passed 1,392 SDK tests, 881 Python tests plus 100 subtests, 109 MCP tests, builds, portable source checks and the 600-entry installed-package check. These are tip checks, separate from own-head probes. No local Windows run was performed. The tip excludes the dependency update merged separately in #1184; combined validation remains outstanding.
No serious outstanding finding introduced by this PR. Code approval is separate from CI and merge readiness.
Consolidate approved Deep Scan changes into the parent topic branch.
b94940c
into
mdangelo/codex/pr939-split-43-retired-coordinator
Part 44 of 46. Previous: #1166 · Next: #1168 · Stack index
Summary
Delete worker launch and permission code used only by the retired coordinator.
Changes
Testing
Checks against the complete stack passed: SDK and MCP typechecks, formatting, Ruff, the SDK build, portable plugin compatibility and its tests, focused recovery/accounting tests, and local-artifact package smoke using exact cached dependencies. The package check was not a clean registry install. See this PR’s Checks tab for CI results for its current commit.
Risk and rollout
This follows coordinator deletion. Active SDK launch settings and native executable selection continue through the shared implementation introduced earlier.
Public disclosure review