Skip to content

refactor(ci): reuse Markdown tool setup - #1215

Merged
mldangelo-oai merged 3 commits into
mainfrom
refactor/markdown-tool-setup
Oct 4, 2026
Merged

mldangelo-oai merged 3 commits into
mainfrom
refactor/markdown-tool-setup

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Markdown-only CI repeats the package-manager and Node setup already provided by the shared action. Reuse that action with identical versions, cache settings, conditions and ordering.

Changes

  • Replace the two setup steps with the existing composite action.
  • Keep the CI-scope test checking the consolidated step in all nine existing cases.

Testing

  • Fresh release-automation tests passed: 292 cases, including all nine CI-scope cases. Existing actionlint/ShellCheck, zizmor and Prettier checks passed for the unchanged workflow patch.
  • The five portable source checks passed. SDK changes passed types and normal formatting; MCP changes passed MCP typecheck and relevant formatting checks.
  • The combined integration tree is byte-identical to the previously validated combined tree: both full SDK runs (3,566 passed, 53 skipped each), 209 MCP checks and installed-package checks remain applicable. These full suites were not rerun for this history-only integration.
  • Three fresh native reviews and an independent verifier passed for this exact base/head. Hosted CI and Codex/Copilot reviews run on the updated head.

Risk and rollout

No commands, public configuration, dependencies or required jobs change. This is an independent follow-up to the landed build cleanup. Latest main at dff04368 is merged; the workflow contribution is unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T05:05:26.900996Z 832caec Manual request
🔒 Security Review ✅ Completed 2026-10-04T05:05:04.108882Z 832caec New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review the current head 0c486e6.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The shared action preserves the existing versions, cache configuration, condition, and execution order.

Review effort: Balanced
Findings: None

What changed in this PR

Reuses the shared TypeScript tool setup action for Markdown-only CI without changing behavior.

Changes:

  • Consolidates pnpm and Node.js setup into the existing composite action.
  • Updates CI-scope tests for the consolidated step.
File Description
.github/​workflows/​node-ci.yml Replaces duplicated setup steps with setup-tools.
sdk/​typescript/​tests-ts/​release-automation.test.ts Updates expected conditional setup step.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 0c486e66e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review the current head 832caec.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The shared action preserves the previous versions, cache configuration, condition, and execution order.

Review effort: Balanced
Findings: None

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 832caecd50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai
mldangelo-oai merged commit 40ca4ad into main Oct 4, 2026
90 of 117 checks passed
@mldangelo-oai
mldangelo-oai deleted the refactor/markdown-tool-setup branch October 4, 2026 08:09
@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants