Skip to content

refactor(release): share provenance verification plumbing - #1233

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/simplify-12-release
Oct 5, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/simplify-12-release

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Release verification repeats provenance-bundle decoding and CLI input/output plumbing. Share that code while retaining normal and recovered verification behavior.

Changes

  • Extract the repeated SLSA bundle lookup, payload decoding and parsing.
  • Share four verifier command branches behind their existing exact command and argument-count guards.
  • Keep GitHub provenance environment parsing conditional on its original command and retain full recovery revalidation.

Testing

Passed on commit edfb3254fd5b:

  • From the repository root: pnpm --dir sdk/typescript run build:ci — passed.
  • From sdk/typescript: pnpm run build:plugin, pnpm run types, and pnpm run format — passed.
  • From sdk/typescript: bun test --timeout 30000 --seed 12345 tests-ts/release-automation.test.ts tests-ts/release-pr.test.ts tests-ts/release-cut-workflow.test.ts — 367 passed, 0 failed.
  • From sdk/typescript: pnpm run test --seed 12345 — 3,566 passed, 53 skipped, 0 failed.
  • From sdk/typescript: pnpm run test — 3,566 passed, 53 skipped, 0 failed; randomized seed 2899968562.

Three independent Codex reviews and separate verification completed without findings.

Risk and rollout

This code checks release provenance. Validation order, diagnostics, archive checks and recovered-run verification must remain intact. No release command syntax, publication permission or provenance requirement changes are introduced.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review the current head SHA.

@mldangelo-oai
mldangelo-oai requested a balanced review from Copilot October 4, 2026 21:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T21:56:43.368105Z edfb325 Manual request
🔒 Security Review ✅ Completed 2026-10-04T21:57:21.597736Z edfb325 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The refactor preserves validation order, command arguments, diagnostics, and recovered provenance checks.

Review effort: Balanced
Findings: None

What changed in this PR

Refactors release provenance verification while preserving existing validation behavior.

Changes:

  • Extracts shared SLSA provenance decoding.
  • Consolidates four verifier CLI branches without changing command guards.
  • Preserves conditional GitHub provenance parsing and recovery revalidation.
File Description
sdk/​typescript/​scripts/​release-automation.mjs Shares provenance parsing and verifier command plumbing.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: edfb3254fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the actual PR diff at edfb3254fd5bbbd3f55e2f0ce0578976a41aad4e against explicit base b96739d5ba184bc745f7ce97605781f97eaf0a66 with three independent HIGH full-diff passes and root synthesis, including every changed test and fixture. No supported introduced issue was identified.

Read all159 actual GitHub diff lines and touched provenance/dispatch context. Extracted parsing and shared dispatch preserve argument counts, values, selected environment parsing and validation calls. Actual GitHub merge base differs from explicit base; the touched file has no inherited-base difference. No release or signature operation executed.

Static source review only; no local tests, builds, release operations or models were run. Source approval does not establish current CI, integration or deployment.

@mldangelo-oai
mldangelo-oai merged commit 63cadfe into main Oct 5, 2026
62 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/simplify-12-release branch October 5, 2026 07:06
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants