Repository navigation
feat(api): add GCP external storage providers - #1125
Conversation
Castiron custom code✅ No new custom-code files detected. 93 mixed files remain; 0 existing customizations changed. Compared 93 existing customizations unchanged
53 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36883931777 --repo openai/openai-java \
--name castiron-custom-code-36883931777-1 --dir /tmp/castiron-custom-code-36883931777-1
git apply --stat /tmp/castiron-custom-code-36883931777-1/custom-code.patch
cat /tmp/castiron-custom-code-36883931777-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 36841eaa0534a932ef2f9674fb2299c7d75e8913 7373328385ee36a5729151fcf262e4fc7e8e2770
python3 scripts/castiron/custom_code_report.py report \
--base 36841eaa0534a932ef2f9674fb2299c7d75e8913 \
--head 7373328385ee36a5729151fcf262e4fc7e8e2770 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-7373328385ee
cat /tmp/castiron-custom-code-7373328385ee/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed d685b9e. GCP request/response fields match the schema, and all three provider unions carry the new type through serialization, validation and typed handlers. The deprecated Visitor method set is preserved; GCP follows the existing unknown/default path, including values created with builders. No blocking findings.
Hosted tests, API compatibility, Jackson compatibility, Java 8/25 runtime checks, lint, build and Castiron checks passed on this head. Review was source-only; I did not run local tests or the author’s separate binary-compatibility probes.
Castiron-Internal-PR: openai/openai-java-internal#200 Castiron-Source-SHA: ec00f549b6b740fc4267d4afe8aecd76c6fcd71f Castiron-Public-Base-SHA: 36841ea
d685b9e to
7373328
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed 7373328. No actionable findings.
Checked all 7 changed files and the surrounding schema, Jackson, validation, and provider-dispatch paths. GCP request fields match the schema; audience and region remain response-only. All three unions support typed GCP dispatch, serialization, and validation while preserving the legacy Visitor method set and routing GCP through its unknown fallback. Handler defaults remain payload-free when unregistered. The 5 changed Kotlin source/test blobs are identical to the previously reviewed d685b9e revision.
Hosted tests, API/Jackson compatibility, Java 8/25 runtime checks, build, lint, and Castiron checks pass on this head. This was a source review; I did not rerun local SDK tests or the author's binary-compatibility probes.
Automated Release PR --- ## [4.74.0](openai/openai-java@v4.73.0...v4.74.0) (2026-10-01) ### Features * **agents:** [1/n] Add typed final answers to beta Agents streams ([openai#1128](openai#1128)) ([b0b7b22](openai@b0b7b22)) * **api:** add GCP external storage providers ([openai#1125](openai#1125)) ([5d7af58](openai@5d7af58)) * collect final output from beta Agents streams ([openai#1124](openai#1124)) ([328958a](openai@328958a)) ### Bug Fixes * **api:** allow original image detail in Chat Completions ([openai#1126](openai#1126)) ([4ae27f8](openai@4ae27f8)) * **api:** correct the eval run cancellation endpoint ([openai#1122](openai#1122)) ([ab795dd](openai@ab795dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
3 participants
Summary
Adds typed Google Cloud Storage providers for organization external storage.
Changes
Handler.builder().onGcp(...)for storage configuration, creation, and registration audit events.unknownfallback.Compatibility
Existing visitors do not gain a required
visitGcpmethod. Existing handlers use theironDefaultcallback for GCP, or the existing payload-free error when no fallback is registered. The GCP request includes workload identity fields; region and audience remain response-only.Validation
7373328: full tests, API compatibility, Jackson compatibility, Java 8/25 runtime checks, build, lint, and generation baseline/budget checks. The test job passed on retry after Maven Central returned HTTP 429 during dependency downloads.