Repository navigation
feat(api): add prewarmed hosted environments - #1155
Conversation
Castiron custom codeEvaluated main: Mixed files: 102 → 105 3 newly customized · 0 customizations removed · 0 existing customizations changed · 5 generated baselines changed Compared
99 existing customizations unchanged
59 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37863650781 --repo openai/openai-java \
--name castiron-custom-code-37863650781-1 --dir /tmp/castiron-custom-code-37863650781-1
git apply --stat /tmp/castiron-custom-code-37863650781-1/custom-code.patch
cat /tmp/castiron-custom-code-37863650781-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin e887c46208c575faf7163721f71e4d8d15256dfc 080fd78823c48a8070358807317551b9ae7a42fa
python3 scripts/castiron/custom_code_report.py report \
--base e887c46208c575faf7163721f71e4d8d15256dfc \
--head 080fd78823c48a8070358807317551b9ae7a42fa --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-080fd78823c4
cat /tmp/castiron-custom-code-080fd78823c4/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed b59caced025155fd7b381d74af50dca94d2c75a4; no blocking source findings. Sync and async creation generate one idempotency key before retries and preserve caller keys. Pagination carries filters forward; environment-ID attachment and ready/failed webhook parsing follow the schema. New webhook visitor methods retain the unknown-event fallback, and create diagnostics redact configuration without changing JSON. The large generated create model represents a narrower contract than the session environment union and reuses shared nested types.
Hosted build, lint, Jackson/API compatibility, Java 8/25 runtime, version-support, and Castiron checks passed. The test job failed in the unchanged AgentTurnResultsTest async-cancellation test, and the required gate failed with it; its cause remains unverified. This approval does not establish green CI. Validation was source-only; I did not run repository workloads or exercise the live prewarming service. Beta access and the agents=v1 header remain required. This review does not establish server rollout or release readiness.
Castiron-Internal-PR: openai/openai-java-internal#223 Castiron-Source-SHA: a3c9c78bb5f6646fcd966efd706c439f8db64568 Castiron-Public-Base-SHA: 130684e
b59cace to
080fd78
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
Prepare an OpenAI-hosted environment before creating a beta Agents session. Add environment creation and paginated listing, session attachment by environment ID, the standalone ready status, and ready/failed webhook parsing. Prewarming access and
OpenAI-Beta: agents=v1remain required.Environment creation generates one idempotency key per call and reuses it across retries. Explicit caller keys retain precedence. Diagnostic strings redact environment configuration without changing request serialization. Existing webhook visitors retain their unknown-event fallback.