Repository navigation
feat(api): add agent environment webhook events and vault updates - #1159
Conversation
Castiron-Internal-PR: openai/openai-java-internal#229 Castiron-Source-SHA: 37a5e762d17dfcaed173a67338e5aefda3de7bee Castiron-Public-Base-SHA: a22dd21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 105 mixed files remain; 0 existing customizations changed; 9 generated baselines changed. Compared
96 existing customizations unchanged
56 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38001170653 --repo openai/openai-java \
--name castiron-custom-code-38001170653-1 --dir /tmp/castiron-custom-code-38001170653-1
git apply --stat /tmp/castiron-custom-code-38001170653-1/custom-code.patch
cat /tmp/castiron-custom-code-38001170653-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin a22dd21ba519a6458881d8e7274fb431639d9755 d3e73459222c19ebdc641cb9db08656e9322cc29
python3 scripts/castiron/custom_code_report.py report \
--base a22dd21ba519a6458881d8e7274fb431639d9755 \
--head d3e73459222c19ebdc641cb9db08656e9322cc29 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-d3e73459222c
cat /tmp/castiron-custom-code-d3e73459222c/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed all 74 changed files at d3e73459222c19ebdc641cb9db08656e9322cc29; no blocking findings.
Checked the new environment-event unions and legacy Visitor fallbacks, vault update/query serialization and blocking/async parity, spending-control missing/null behavior, OCI provider models, optional safety explanations, and public-schema consistency. The existing public OCI Visitors remain unchanged (new abstract dispatch methods are private), and the Live source/signature surface is unchanged. The transformed-schema hash and read-only contract checks pass.
Validation was immutable-source review, including independent webhook/compatibility and vault/spending passes, plus static parsed-schema checks—not a local Gradle/JVM test run. Public exact-head build, lint, build-logic and baseline checks passed; API/Jackson/runtime compatibility and test jobs were still running at review time. Existing CI and owner gates still apply.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed d3e73459222c19ebdc641cb9db08656e9322cc29; I found no actionable issues in the 74-file diff.
The environment-event dispatch preserves existing Visitor implementations and the unknown-event fallback. Vault updates and metadata filters match across blocking and async clients. Spending controls preserve the required distinctions between missing values and explicit nulls. OCI provider models, optional safety explanations, and the transformed schema are consistent. Existing Live signatures remain unchanged.
Public build, lint, Jackson, API compatibility, and Java 8/25 runtime checks have passed. The main test job is still running, so this approval does not claim a full public CI pass. Validation was source review and hosted CI evidence; I did not run Gradle or JVM tests locally.
3 participants
Summary
Adds typed agent environment lifecycle events and vault update and filtering support.
Changes
Validation