Repository navigation
feat(api): add shida to named Live voices - #1163
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-java-internal#235 Castiron-Source-SHA: 3333fe3bbf5691a5c362521238bdab021db3a195 Castiron-Public-Base-SHA: d3f1053
jbeckwith-oai
marked this pull request as ready for review
October 11, 2026 01:53
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Castiron custom codeEvaluated main: Mixed files: 105 → 108 3 newly customized · 0 customizations removed · 0 existing customizations changed · 3 generated baselines changed Compared
105 existing customizations unchanged
65 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38103351642 --repo openai/openai-java \
--name castiron-custom-code-38103351642-1 --dir /tmp/castiron-custom-code-38103351642-1
git apply --stat /tmp/castiron-custom-code-38103351642-1/custom-code.patch
cat /tmp/castiron-custom-code-38103351642-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin d3f1053b905da920e69692ed3856e41bf10b3cd8 8dd467d8456cd6760a844d1bca7ca2493f2cc696
python3 scripts/castiron/custom_code_report.py report \
--base d3f1053b905da920e69692ed3856e41bf10b3cd8 \
--head 8dd467d8456cd6760a844d1bca7ca2493f2cc696 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-8dd467d8456c
cat /tmp/castiron-custom-code-8dd467d8456c/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Contributor
markstuart-oai
approved these changes
Oct 11, 2026
markstuart-oai
left a comment
markstuart-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 8dd467d. No actionable findings.
The new SHIDA constant, both enum entries, and both mappings agree on shida. All 22 existing voice names and wire values remain intact. The string overload and unknown-value handling remain unchanged, and the full API reference differs only by the new voice entry. The change follows the existing generated structure without adding complexity.
Source and static review only; I did not run repository tests or generation. The build and external OkTest run were still in progress at the final check, so those gates remain pending.
yoni-oai
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds shida to the named built-in Live voices.
Changes