Skip to content

Repository navigation

feat(api): add organization external key management - #1302

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-393
Oct 28, 2026
Merged

feat(api): add organization external key management#1302
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-393

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds organization external-key registration and validation for AWS, GCP and Azure.

Changes

  • Create, retrieve, list, delete and validate organization external-key registrations.
  • Filter external-key listings by purpose and paginate through results.

@jbeckwith-oai
feat(api): add organization external key management
d844be3 
Castiron-Internal-PR: openai/openai-java-internal#393
Castiron-Source-SHA: d590426f9038bba7da1d2e439c2a6533636566ed
Castiron-Public-Base-SHA: 03f24db
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 28, 2026 21:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T21:10:14.665312Z d844be3 PR opened
🔒 Security Review ✅ Completed 2026-10-28T21:10:49.690070Z d844be3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 28, 2026
markstuart-oai
markstuart-oai approved these changes Oct 28, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed d844be34, including the external-key models, sync/async services and the new HTTP contract tests. No actionable defects found.

The 34 previously reviewed file changes match the internal candidate exactly. I reviewed the remaining contract test and verified the supporting authentication and paging code. The tests cover AWS, GCP and Azure request bodies, admin authentication, pagination filters and deletion. The generated model size is justified by the nested public API and consistent generated layout.

Exact-head hosted CI passed, including SDK tests, API compatibility, Java 8/25 runtime checks, Jackson compatibility and OkTest. Independent source review reached the same conclusion. No local tests or candidate code were run.

Merged via the queue into main with commit b0407aa Oct 28, 2026
14 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Oct 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes
@dpiet-oai dpiet-oai dpiet-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbeckwith-oai @markstuart-oai @dpiet-oai