Skip to content

chore(api): document decision choice constraints - #2914

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-266
Oct 11, 2026
Merged

chore(api): document decision choice constraints#2914
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-266

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Clarifies the number and uniqueness requirements for decision choices.

Changes

  • Document that choice questions require between 2 and 255 unique choices.

@jbeckwith-oai
chore(api): document decision choice constraints
abba3ff 
Castiron-Internal-PR: openai/openai-node-internal#266
Castiron-Source-SHA: f62aabf0822433890eb7dcd218a845b50633a9f2
Castiron-Public-Base-SHA: 1c380ea
@github-actions

github-actions Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 1c380ea1e538d37f80654dffe36b1a25e9e61011.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed; 1 generated baselines changed.

Compared 1c380ea1e538 → abba3ff6b6bf. Generated baselines verified.

File Result Current custom patch
src/client.ts Generated baseline changed +887 / −109
49 existing customizations unchanged
  • api.md
  • scripts/castiron/CUSTOM_CODE.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/agents/agents.ts
  • src/resources/beta/agents/environments/environments.ts
  • src/resources/beta/agents/environments/files.ts
  • src/resources/beta/agents/sessions/artifacts.ts
  • src/resources/beta/agents/sessions/sessions.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/responses/ws-base.ts
  • src/resources/beta/responses/ws.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/live/forks/ws-base.ts
  • src/resources/live/forks/ws.ts
  • src/resources/live/sideband/ws-base.ts
  • src/resources/live/sideband/ws.ts
  • src/resources/live/ws-base.ts
  • src/resources/live/ws.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/responses/ws-base.ts
  • src/resources/responses/ws.ts

9 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38113151599 --repo openai/openai-node \
  --name castiron-custom-code-38113151599-1 --dir /tmp/castiron-custom-code-38113151599-1
git apply --stat /tmp/castiron-custom-code-38113151599-1/custom-code.patch
cat /tmp/castiron-custom-code-38113151599-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 1c380ea1e538d37f80654dffe36b1a25e9e61011 abba3ff6b6bf5818027bfa2e552f2f20da56fbe7
python3 scripts/castiron/custom_code_report.py report \
  --base 1c380ea1e538d37f80654dffe36b1a25e9e61011 \
  --head abba3ff6b6bf5818027bfa2e552f2f20da56fbe7 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-abba3ff6b6bf
cat /tmp/castiron-custom-code-abba3ff6b6bf/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 04:55
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 04:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T04:57:14.538779Z abba3ff Draft marked ready
🔒 Security Review ✅ Completed 2026-10-11T05:00:22.792145Z abba3ff Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 8.664s for Node SDK PR #2914.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 182ms
tests/chat-completions-create.test.ts ✅ Passed 170ms
tests/chat-completions-stream.test.ts ✅ Passed 142ms
tests/files-content-binary.test.ts ✅ Passed 183ms
tests/files-create-multipart.test.ts ✅ Passed 223ms
tests/files-list-pagination.test.ts ✅ Passed 139ms
tests/initialize-config.test.ts ✅ Passed 172ms
tests/instance-isolation.test.ts ✅ Passed 198ms
tests/models-list.test.ts ✅ Passed 213ms
tests/responses-background-lifecycle.test.ts ✅ Passed 173ms
tests/responses-body-method-errors.test.ts ✅ Passed 285ms
tests/responses-cancel-timeout.test.ts ✅ Passed 219ms
tests/responses-cancel.test.ts ✅ Passed 211ms
tests/responses-compact-retries.test.ts ✅ Passed 234ms
tests/responses-compact.test.ts ✅ Passed 182ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 149ms
tests/responses-create-advanced.test.ts ✅ Passed 172ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.124s
tests/responses-create-errors.test.ts ✅ Passed 208ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 209ms
tests/responses-create-retries.test.ts ✅ Passed 260ms
tests/responses-create-stream-failures.test.ts ✅ Passed 162ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.159s
tests/responses-create-stream-wire.test.ts ✅ Passed 1.354s
tests/responses-create-stream.test.ts ✅ Passed 124ms
tests/responses-create-terminal-states.test.ts ✅ Passed 223ms
tests/responses-create-timeout.test.ts ✅ Passed 235ms
tests/responses-create.test.ts ✅ Passed 183ms
tests/responses-delete.test.ts ✅ Passed 239ms
tests/responses-input-items-errors.test.ts ✅ Passed 188ms
tests/responses-input-items-list.test.ts ✅ Passed 231ms
tests/responses-input-items-options.test.ts ✅ Passed 166ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 281ms
tests/responses-input-tokens-count.test.ts ✅ Passed 199ms
tests/responses-malformed-inputs.test.ts ✅ Passed 946ms
tests/responses-not-found-errors.test.ts ✅ Passed 194ms
tests/responses-parse.test.ts ✅ Passed 199ms
tests/responses-retrieve-retries.test.ts ✅ Passed 207ms
tests/responses-retrieve.test.ts ✅ Passed 197ms
tests/responses-stored-method-errors.test.ts ✅ Passed 381ms
tests/retry-behavior.test.ts ✅ Passed 3.23s
tests/sdk-error-shape.test.ts ✅ Passed 271ms

View OkTest run #38113133583

SDK merge (72099982d6ca) · head (abba3ff6b6bf) · base (1c380ea1e538) · OkTest (59813f410948)

markstuart-oai
markstuart-oai approved these changes Oct 11, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all three changed files at abba3ff6b6bf5818027bfa2e552f2f20da56fbe7. No actionable findings.

The full schema comparison adds only the choice description: provide 2–255 choices, with each choice unique. The TypeScript field documentation matches it. Executable code, type declarations, schema constraints and configuration are unchanged. The public generator snapshot resolves and has no .github/workflows directory.

Current-head CI passed, including the Node.js test matrix. The external OkTest run also passed for this head and base. This was a source-only review; I ran no repository tests, builds or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 3add470 Oct 11, 2026
63 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-266 branch October 11, 2026 05:08
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai