Skip to content

feat(api): add OCI external-storage provider support - #2917

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-273
Oct 11, 2026
Merged

feat(api): add OCI external-storage provider support#2917
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-273

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds OCI to external-storage provider requests and responses.

Changes

  • Configure an OCI provider with its tenancy OCID, region, and bucket.
  • Recognize OCI alongside existing AWS, Azure, and GCP providers.

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 20:31
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 20:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T22:24:20.673205Z a574d2a New commits
🔒 Security Review ✅ Completed 2026-10-11T22:24:45.775836Z a574d2a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: f57c9651c8d22ae82cacca27317cfa7126491011.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed; 7 generated baselines changed.

Compared f57c9651c8d2 → a574d2a919c2. Generated baselines verified.

File Result Current custom patch
api.md Generated baseline changed +28 / −0
src/client.ts Generated baseline changed +829 / −98
src/resources/beta/responses/ws-base.ts Generated baseline changed +70 / −11
src/resources/live/forks/ws-base.ts Generated baseline changed +1 / −1
src/resources/live/sideband/ws-base.ts Generated baseline changed +1 / −1
src/resources/live/ws-base.ts Generated baseline changed +1 / −1
src/resources/responses/ws-base.ts Generated baseline changed +75 / −14
43 existing customizations unchanged
  • scripts/castiron/CUSTOM_CODE.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/agents/agents.ts
  • src/resources/beta/agents/environments/environments.ts
  • src/resources/beta/agents/environments/files.ts
  • src/resources/beta/agents/sessions/artifacts.ts
  • src/resources/beta/agents/sessions/sessions.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/responses/ws.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/live/forks/ws.ts
  • src/resources/live/sideband/ws.ts
  • src/resources/live/ws.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/responses/ws.ts
  • src/resources/skills/skills.ts
  • src/resources/skills/versions/versions.ts
  • src/resources/vector-stores/file-batches.ts
  • src/resources/vector-stores/files.ts
  • src/resources/webhooks/index.ts
  • src/resources/webhooks/webhooks.ts

3 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38180225290 --repo openai/openai-node \
  --name castiron-custom-code-38180225290-1 --dir /tmp/castiron-custom-code-38180225290-1
git apply --stat /tmp/castiron-custom-code-38180225290-1/custom-code.patch
cat /tmp/castiron-custom-code-38180225290-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin f57c9651c8d22ae82cacca27317cfa7126491011 a574d2a919c256c53b6b321a30c4dd0119ef4015
python3 scripts/castiron/custom_code_report.py report \
  --base f57c9651c8d22ae82cacca27317cfa7126491011 \
  --head a574d2a919c256c53b6b321a30c4dd0119ef4015 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-a574d2a919c2
cat /tmp/castiron-custom-code-a574d2a919c2/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@openai-sdks

openai-sdks Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 7.221s for Node SDK PR #2917.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 160ms
tests/chat-completions-create.test.ts ✅ Passed 147ms
tests/chat-completions-stream.test.ts ✅ Passed 114ms
tests/files-content-binary.test.ts ✅ Passed 117ms
tests/files-create-multipart.test.ts ✅ Passed 110ms
tests/files-list-pagination.test.ts ✅ Passed 106ms
tests/initialize-config.test.ts ✅ Passed 166ms
tests/instance-isolation.test.ts ✅ Passed 144ms
tests/models-list.test.ts ✅ Passed 98ms
tests/responses-background-lifecycle.test.ts ✅ Passed 125ms
tests/responses-body-method-errors.test.ts ✅ Passed 202ms
tests/responses-cancel-timeout.test.ts ✅ Passed 212ms
tests/responses-cancel.test.ts ✅ Passed 128ms
tests/responses-compact-retries.test.ts ✅ Passed 148ms
tests/responses-compact.test.ts ✅ Passed 152ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 142ms
tests/responses-create-advanced.test.ts ✅ Passed 126ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.03s
tests/responses-create-errors.test.ts ✅ Passed 199ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 89ms
tests/responses-create-retries.test.ts ✅ Passed 236ms
tests/responses-create-stream-failures.test.ts ✅ Passed 125ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.142s
tests/responses-create-stream-wire.test.ts ✅ Passed 1.143s
tests/responses-create-stream.test.ts ✅ Passed 121ms
tests/responses-create-terminal-states.test.ts ✅ Passed 157ms
tests/responses-create-timeout.test.ts ✅ Passed 248ms
tests/responses-create.test.ts ✅ Passed 153ms
tests/responses-delete.test.ts ✅ Passed 133ms
tests/responses-input-items-errors.test.ts ✅ Passed 143ms
tests/responses-input-items-list.test.ts ✅ Passed 127ms
tests/responses-input-items-options.test.ts ✅ Passed 122ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 227ms
tests/responses-input-tokens-count.test.ts ✅ Passed 204ms
tests/responses-malformed-inputs.test.ts ✅ Passed 700ms
tests/responses-not-found-errors.test.ts ✅ Passed 171ms
tests/responses-parse.test.ts ✅ Passed 122ms
tests/responses-retrieve-retries.test.ts ✅ Passed 192ms
tests/responses-retrieve.test.ts ✅ Passed 132ms
tests/responses-stored-method-errors.test.ts ✅ Passed 330ms
tests/retry-behavior.test.ts ✅ Passed 2.838s
tests/sdk-error-shape.test.ts ✅ Passed 247ms

View OkTest run #38180203866

SDK merge (66ec9418a16c) · head (a574d2a919c2) · base (f57c9651c8d2) · OkTest (56d7bfc8ad08)

markstuart-oai
markstuart-oai approved these changes Oct 11, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 4 changed files at 7c3c22a26f26985a14bf704cb2f3445dac35af3f.

No blocking findings. The OCI request and response interfaces match the schema: bucket, region, tenancy_ocid, and the literal oci discriminator. Existing providers and the optional audit-data container remain unchanged. The existing create method forwards the typed body through the same request path.

The response interfaces have compatible structural shapes. This change adds no runtime transport or authentication logic.

I verified the full diff, immutable source hashes, merge base, and matching schema changes across all four SDK candidates. Exact-head CI reports 35 successful and 26 skipped checks, with 1 check still running or queued. This was a source-only review; I did not run tests, builds, generation, or SDK execution.

@jbeckwith-oai
feat(api): add OCI external-storage provider support
a574d2a 
Castiron-Internal-PR: openai/openai-node-internal#273
Castiron-Source-SHA: 4c0a4ad8570c90a7d68232fd9bd572f4a9383738
Castiron-Public-Base-SHA: f57c965
@jbeckwith-oai
jbeckwith-oai force-pushed the castiron/promotions/pr-273 branch from 7c3c22a to a574d2a Compare October 11, 2026 22:22
@jbeckwith-oai
jbeckwith-oai requested a review from a team October 11, 2026 22:27
@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 80e210e Oct 11, 2026
40 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-273 branch October 11, 2026 22:52
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes
@dpiet-oai dpiet-oai dpiet-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbeckwith-oai @markstuart-oai @dpiet-oai