Skip to content

feat(api): support image URLs and detailed safety alert explanations - #2918

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-274
Oct 11, 2026
Merged

feat(api): support image URLs and detailed safety alert explanations#2918
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-274

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Document HTTP(S) image URLs for Decisions inputs and expose detailed safety alert explanations.

Changes

  • Document publicly accessible HTTP(S) image URLs alongside base64 data URLs in Decisions inputs.
  • Add optional detailed_explanation to safety alerts when an explanation is available for an eligible zero data retention alert.

@jbeckwith-oai
feat(api): support image URLs and detailed safety alert explanations
d60eab1 
Castiron-Internal-PR: openai/openai-node-internal#274
Castiron-Source-SHA: 69a63343331a85ed661cbf5aa73e3fb950b1e8e2
Castiron-Public-Base-SHA: 80e210e
@github-actions

github-actions Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 80e210e00c05be3c631baa01ab2113383fdc5268.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed.

Compared 80e210e00c05 → d60eab1d0a04. Generated baselines verified.

50 existing customizations unchanged
  • api.md
  • scripts/castiron/CUSTOM_CODE.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py
  • src/client.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/agents/agents.ts
  • src/resources/beta/agents/environments/environments.ts
  • src/resources/beta/agents/environments/files.ts
  • src/resources/beta/agents/sessions/artifacts.ts
  • src/resources/beta/agents/sessions/sessions.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/responses/ws-base.ts
  • src/resources/beta/responses/ws.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/live/forks/ws-base.ts
  • src/resources/live/forks/ws.ts
  • src/resources/live/sideband/ws-base.ts
  • src/resources/live/sideband/ws.ts
  • src/resources/live/ws-base.ts
  • src/resources/live/ws.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/responses/ws-base.ts

10 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38184767583 --repo openai/openai-node \
  --name castiron-custom-code-38184767583-1 --dir /tmp/castiron-custom-code-38184767583-1
git apply --stat /tmp/castiron-custom-code-38184767583-1/custom-code.patch
cat /tmp/castiron-custom-code-38184767583-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 80e210e00c05be3c631baa01ab2113383fdc5268 d60eab1d0a049b5de5e634ade5948bcbee31397c
python3 scripts/castiron/custom_code_report.py report \
  --base 80e210e00c05be3c631baa01ab2113383fdc5268 \
  --head d60eab1d0a049b5de5e634ade5948bcbee31397c --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-d60eab1d0a04
cat /tmp/castiron-custom-code-d60eab1d0a04/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 23:33
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 23:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T23:35:16.001187Z d60eab1 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-11T23:36:11.203227Z d60eab1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 8.637s for Node SDK PR #2918.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 210ms
tests/chat-completions-create.test.ts ✅ Passed 189ms
tests/chat-completions-stream.test.ts ✅ Passed 134ms
tests/files-content-binary.test.ts ✅ Passed 195ms
tests/files-create-multipart.test.ts ✅ Passed 272ms
tests/files-list-pagination.test.ts ✅ Passed 177ms
tests/initialize-config.test.ts ✅ Passed 195ms
tests/instance-isolation.test.ts ✅ Passed 182ms
tests/models-list.test.ts ✅ Passed 267ms
tests/responses-background-lifecycle.test.ts ✅ Passed 201ms
tests/responses-body-method-errors.test.ts ✅ Passed 305ms
tests/responses-cancel-timeout.test.ts ✅ Passed 231ms
tests/responses-cancel.test.ts ✅ Passed 191ms
tests/responses-compact-retries.test.ts ✅ Passed 230ms
tests/responses-compact.test.ts ✅ Passed 220ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 158ms
tests/responses-create-advanced.test.ts ✅ Passed 219ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.081s
tests/responses-create-errors.test.ts ✅ Passed 188ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 128ms
tests/responses-create-retries.test.ts ✅ Passed 235ms
tests/responses-create-stream-failures.test.ts ✅ Passed 136ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.182s
tests/responses-create-stream-wire.test.ts ✅ Passed 1.256s
tests/responses-create-stream.test.ts ✅ Passed 133ms
tests/responses-create-terminal-states.test.ts ✅ Passed 213ms
tests/responses-create-timeout.test.ts ✅ Passed 220ms
tests/responses-create.test.ts ✅ Passed 209ms
tests/responses-delete.test.ts ✅ Passed 202ms
tests/responses-input-items-errors.test.ts ✅ Passed 171ms
tests/responses-input-items-list.test.ts ✅ Passed 188ms
tests/responses-input-items-options.test.ts ✅ Passed 164ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 270ms
tests/responses-input-tokens-count.test.ts ✅ Passed 221ms
tests/responses-malformed-inputs.test.ts ✅ Passed 968ms
tests/responses-not-found-errors.test.ts ✅ Passed 257ms
tests/responses-parse.test.ts ✅ Passed 274ms
tests/responses-retrieve-retries.test.ts ✅ Passed 233ms
tests/responses-retrieve.test.ts ✅ Passed 186ms
tests/responses-stored-method-errors.test.ts ✅ Passed 414ms
tests/retry-behavior.test.ts ✅ Passed 2.955s
tests/sdk-error-shape.test.ts ✅ Passed 256ms

View OkTest run #38184745047

SDK merge (534a83df10e4) · head (d60eab1d0a04) · base (80e210e00c05) · OkTest (511bfd40fa1f)

markstuart-oai
markstuart-oai approved these changes Oct 11, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed d60eab1d0a049b5de5e634ade5948bcbee31397c. No actionable correctness or maintainability findings.

The Decisions documentation and schema now allow publicly accessible HTTP(S) image URLs alongside data URLs. The request body still carries strings, with no new client-side fetching. SafetyAlert.detailed_explanation?: string | null accurately represents omission, null, and string values.

Source-only review of all 4 changed files against the pinned base. CI still had checks running at inspection. I did not run tests or builds.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 8297332 Oct 11, 2026
63 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-274 branch October 11, 2026 23:46
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai