Repository navigation
feat(api): support audio fixture playback in Live sessions - #2946
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: Mixed files: 47 → 50 3 newly customized · 0 customizations removed · 0 existing customizations changed · 3 generated baselines changed Compared
47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38814397284 --repo openai/openai-node \
--name castiron-custom-code-38814397284-1 --dir /tmp/castiron-custom-code-38814397284-1
git apply --stat /tmp/castiron-custom-code-38814397284-1/custom-code.patch
cat /tmp/castiron-custom-code-38814397284-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 35bfd1f8832cb199e0b210a9a5d698f158f8c000 7420666147d42794ace1e4da55489569b4161ace
python3 scripts/castiron/custom_code_report.py report \
--base 35bfd1f8832cb199e0b210a9a5d698f158f8c000 \
--head 7420666147d42794ace1e4da55489569b4161ace --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-7420666147d4
cat /tmp/castiron-custom-code-7420666147d4/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f55082ae6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Castiron-Internal-PR: openai/openai-node-internal#301 Castiron-Source-SHA: 5a2d2f47630e354666d32d56080f95833868885e Castiron-Public-Base-SHA: 35bfd1f
f55082a to
7420666
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed all nine changed files at 7420666. No blocking issues found.
The earlier WebRTC concern is fixed: both OpenAILiveWebRTC and LiveDataChannel exclude fixture.play from their outgoing event union while retaining the server acknowledgments. Primary/fork/sideband WebSocket unions, nullable event_id handling, queue/no-replay behavior, and the changed public-snapshot manifest hashes also check out.
Static source/security review only; no local tests or live calls. Current hosted checks are green. The Node 22 log includes all 53 WebRTC tests plus successful packed CJS/ESM/browser checks; Node 24 and 26 jobs are also green.
3 participants
Summary
Send an audio fixture in a Live session and use the typed events to follow its playback.
Changes
session.output_audio.fixture.play.session.output_audio.fixture.playingwhen the server accepts the audio, and correlate it with the play event usingclient_event_id.session.output_audio.fixture.playedwhen the server mixer drains. Audio buffered by the transport may still be playing.