fix: raspi installation error (openai/retro#242)#251
Open
mapostolidou wants to merge 1 commit intoopenai:masterfrom
Open
fix: raspi installation error (openai/retro#242)#251mapostolidou wants to merge 1 commit intoopenai:masterfrom
mapostolidou wants to merge 1 commit intoopenai:masterfrom
Conversation
endrift
approved these changes
Sep 23, 2021
Contributor
endrift
left a comment
endrift
left a comment
There was a problem hiding this comment.
LGTM, though I don't have merge access anymore.
squishyhuman
pushed a commit
to RetroAI/retro3
that referenced
this pull request
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template is declared just under the if statement so if the code reaches the elif at line 490 it is out of scope.
I solved it by inserting a line after the elif (line 490) and with template so that the template is declared even when the code runs from the elif.
It should work fine if you also move the template from line 480 and place it before the if block but I didn't test that.