feat(ai): accept MiniMax-M3 as a supported vision model#191
Conversation
Add MiniMax-M3 to the CLI's supported MiniMax inputs so `minimax/MiniMax-M3` (and aliases) resolves to a vision-capable model for screenshot analysis. - AgentCommand+ModelParsing: include `.m3` in supportedMiniMaxInputs - Tests: M3 parse cases in AgentCommandModelParsingTests and AIProviderParserTests - Bump Tachikoma submodule for the matching MiniMax-M3 enum + vision + parser change (see openclaw/Tachikoma#26)
|
Codex review: needs real behavior proof before merge. Reviewed June 20, 2026, 4:03 AM ET / 08:03 UTC. Summary Reproducibility: yes. from source inspection: current main gates MiniMax parsing through Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land complete MiniMax-M3 support in Tachikoma first, update this PR's gitlink to the accepted upstream main commit, restore MiniMax China parser coverage, and include redacted terminal or log proof from a real MiniMax-M3 analysis run. Do we have a high-confidence way to reproduce the issue? Yes, from source inspection: current main gates MiniMax parsing through Is this the best way to solve the issue? No as submitted. The Peekaboo parser change is narrow, but the maintainable path is to land complete Tachikoma support upstream first, use an accepted submodule commit, preserve existing MiniMax China coverage, and add inspectable real behavior proof. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 9b9c5de43bf0. Label changesLabel justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Enables MiniMax-M3 as a first-class, vision-capable model so it can drive Peekaboo's screenshot/image analysis (
peekaboo see --analyze, MCPsee, etc.).Today the whole MiniMax family is marked
supportsVision = falsein Tachikoma, so configuringminimax/MiniMax-M3fails withNo configured vision-capable AI model is available. With this change (plus the Tachikoma side), M3 works end-to-end for vision.Changes
Apps/CLI/Sources/PeekabooCLI/Commands/AI/AgentCommand+ModelParsing.swift: add.m3tosupportedMiniMaxInputs.Apps/CLI/Tests/CoreCLITests/AgentCommandModelParsingTests.swift: M3 parse assertions + parametrized case.Core/PeekabooCore/Tests/PeekabooTests/AIProviderParserTests.swift:minimax/MiniMax-M3config assertion.supportsVision+ parser entries (depends on feat(models): add MiniMax-M3 with vision support Tachikoma#26).Dependency note
This PR bumps the
Tachikomasubmodule toTugser/Tachikoma@13d0454(the fork commit carrying the M3 enum/parser change) so the Peekaboo side compiles and tests pass. It should be re-pointed to theopenclaw/Tachikomamaincommit once openclaw/Tachikoma#26 merges. Until then, freshgit submodule updateagainst the upstream submodule URL may not resolve the SHA.Test commands executed
All pass. Also verified end-to-end locally:
peekaboo see --mode frontmost --analyze "..."returns a real analysis viaprovider=minimax, model=MiniMax-M3.Builds
swift build --package-path Apps/CLI(debug) ✅./scripts/build-swift-arm.sh(arm64 release, code-signed) ✅