feat(ai): add Kimi (Moonshot) support for CLI vision and agents#192
feat(ai): add Kimi (Moonshot) support for CLI vision and agents#192Tugser wants to merge 1 commit into
Conversation
Surface Kimi K2.6/K2.7 as accepted vision-capable models across the CLI and core AI service, mirroring the MiniMax wiring. - AgentCommand+ModelParsing: supportedKimiInputs, hosted/kimi parsing, credential/displayName/env-var switches, allowed model list - PeekabooAIService: hosted-provider id, hasCredentialsOrLocalRuntime, providerAndModelName, resolveAvailableModels fallback (MOONSHOT_API_KEY) - ConfigurationManager: getKimiAPIKey() (MOONSHOT_API_KEY/KIMI_API_KEY) and applyAIProviderKeys pushes it into Tachikoma config - PeekabooAgentService: defaultModelSelection + apiKey + maxOutputTokens - Tests: Kimi parse cases (CLI + AIProviderParser) - Bump Tachikoma submodule for the Kimi provider (see openclaw/Tachikoma#27)
|
Codex review: needs real behavior proof before merge. Reviewed June 25, 2026, 4:29 PM ET / 20:29 UTC. Summary Reproducibility: not applicable. as a bug report; this PR adds a new provider feature. The credential precedence issue is source-reproducible from the proposed Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land a complete Kimi provider in openclaw/Tachikoma first, repoint Peekaboo to that upstream commit, fix the Kimi credential precedence edge case, and include redacted live CLI proof. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug report; this PR adds a new provider feature. The credential precedence issue is source-reproducible from the proposed Is this the best way to solve the issue? No, not yet. The implementation should first land the upstream Tachikoma provider, preserve established credential precedence, and then prove a real Kimi-backed CLI run with redacted output. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against dda07c245fea. Label changesLabel changes:
Label justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Adds Kimi (Moonshot AI) support so Peekaboo can use Kimi K2.6/K2.7 (via the
kimi/provider prefix) for screenshot analysis and agent flows. Targets the Moonshot coding endpointhttps://api.kimi.com/coding/v1withMOONSHOT_API_KEY.Changes
Apps/CLI/.../AgentCommand+ModelParsing.swift:supportedKimiInputs,kimi/moonshothosted parsing, credential/displayName/env-var switches, allowed-model list.Core/PeekabooCore/.../PeekabooAIService.swift: hosted-provider id,hasCredentialsOrLocalRuntime,providerAndModelName,resolveAvailableModelsfallback.Core/PeekabooCore/.../ConfigurationManager+Accessors.swift:getKimiAPIKey()(MOONSHOT_API_KEY/KIMI_API_KEY) +applyAIProviderKeyspush.Core/PeekabooCore/.../PeekabooAgentService*.swift: defaultModelSelection, apiKey, maxOutputTokens.AgentCommandModelParsingTestsandAIProviderParserTests.Dependency note
Bumps
TachikomatoTugser/Tachikoma@ebcad41so the Peekaboo side compiles and tests pass. Re-point toopenclaw/Tachikomamainonce openclaw/Tachikoma#27 merges.Test commands executed
All pass. End-to-end
peekaboo see --analyzewithkimi/k2p7reachesapi.kimi.com/coding/v1and authenticates (request well-formed, image serialized); final live response depends on the user's Kimi coding-plan membership being active.Usage