docs: refresh Peekaboo agent skill guidance#197
Conversation
|
Codex review: needs changes before merge. Reviewed June 23, 2026, 6:33 PM ET / 22:33 UTC. Summary Reproducibility: yes. Current main still points at Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the focused docs/help refresh after correcting the Do we have a high-confidence way to reproduce the issue? Yes. Current main still points at Is this the best way to solve the issue? No, not quite. The overall docs/help approach is narrow and maintainable, but the Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ab0d96e6d530. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Added redacted terminal proof to the PR body covering the updated |
|
Landed as Maintainer verification:
Live proof: the PR body contains the contributor's redacted Calculator smoke using an explicit Caveat: #194 and #196 remain open; this PR does not claim to change element-ID generation or implicit screenshot persistence. |
Closes #195.
Summary
Refreshes the Peekaboo agent skill and related docs so agent guidance matches the current repository layout and current CLI behavior.
skills/peekaboonameanddescriptionfrontmattersee/inspect-uielement IDs as opaque values copied from fresh output/tmp/... --pathexamples forsee --jsonflowssee --helpexample to avoid JSON-only screenshot ambiguityjqpath to use.data.ui_elementsNotes
Related runtime issues remain open: #194 and #196. This PR updates guidance so it stays compatible with those current behaviors; runtime behavior changes remain tracked separately.
Verification
node scripts/docs-lint.mjspeekaboo-cli,allowed-tools, hardcoded stale ID examples, and unsafesee --jsonexamplespnpm run build:clisee,click,inspect-ui,browser, andtools --jsonhelp/catalog checksseesmoke with explicit/tmpoutput pathgit diff --checkRedacted Terminal Proof
Updated
see --helpExampleDocs Lint And Skill Frontmatter
Calculator Smoke With Explicit
/tmpScreenshot PathProof output is intentionally redacted: no raw UI JSON, screenshot contents, or local home paths are included.