Repository navigation
chore(autoreview): use the shared canonical skill - #229
Conversation
|
Codex review: blocked before merge. Reviewed October 3, 2026, 8:45 PM ET / October 4, 2026, 00:45 UTC (Revision 6). ClawSweeper reviewWhat this changesReplace Gitcrawl’s copied code-review helper, harness, and tests with instructions for using the shared installation, and document the transition. Merge readiness⛔ Blocked before merge - 3 items remain The consolidation remains useful: current main and v0.15.0 retain the copied implementation. No concrete introduced defect was found, but removing the documented local launch paths needs an explicit tooling-transition decision. This member-authored PR is protected from automatic closure. Priority: P3 Review scores
Verification
How this fits togetherAutoreview is developer tooling that reviews selected Git changes and returns structured findings. Gitcrawl currently carries its own copy; this change directs contributors to an installation maintained by openclaw/agent-skills. flowchart TD
A[Contributor Git changes] --> B[Repository skill instructions]
B --> C[Shared skill installation]
C --> D[Helper runs from Gitcrawl]
D --> E[Selected review engine]
E --> F[Structured findings]
Decision needed
Why: The implementation is coherent, but accepting the operator work required by this intentional tooling break needs an explicit owner decision. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Maintain one canonical helper with an approved installation transition and consistent shared-path instructions in Gitcrawl and upstream. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a tooling consolidation rather than a reported runtime bug; source confirms the local launch paths are removed. Is this the best way to solve the issue? Yes, reusing the existing canonical installer and helper avoids maintenance drift; the remaining choice is whether to accept the documented installation transition. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 3f4276c344af. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: chore(autoreview): use the shared canonical skill This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.