Repository navigation
chore(deps): bump modernc.org/sqlite to 1.60.1 - #230
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 3, 2026, 1:23 AM ET / 05:23 UTC (Revision 2). ClawSweeper reviewWhat this changesUpdates Gitcrawl’s SQLite driver to 1.60.1 and refreshes its checksums to adopt faster statement argument binding. Merge readiness✅ Ready for maintainer review The update remains useful: current main has SQLite 1.60.0, and the latest release has 1.59.0. The narrowly scoped patch has no actionable findings or additional merge requirements. Priority: P2 Review scores
Verification
How this fits togetherGitcrawl stores synchronized GitHub archive data in SQLite and publishes portable database snapshots. The driver binds application query arguments before SQLite reads or writes that data. flowchart LR
A[GitHub archive data] --> B[Gitcrawl storage]
B --> C[SQL statements and arguments]
C --> D[SQLite driver binding]
D --> E[Local archive database]
E --> F[Queries and portable snapshots]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Adopt the compatible driver patch while retaining existing storage contracts and the separately planned release schedule. Do we have a high-confidence way to reproduce the issue? Not applicable to this dependency-maintenance PR; upstream source establishes the quadratic binding path and its replacement, but this review did not execute a Gitcrawl performance reproduction. Is this the best way to solve the issue? Yes. A patch-version update adopts the upstream repair without duplicating driver logic or changing Gitcrawl’s configuration or database schema. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 1bb090b38b4c. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
What Problem This Solves
Adopts the upstream fix for quadratic SQLite statement argument binding.
User Impact
Statements with many bound arguments use the driver's linear-time lookup; no Gitcrawl schema, configuration, or storage-format changes.
Why This Change Was Made
Bump
modernc.org/sqlitefromv1.60.0tov1.60.1, retaining exactlymodernc.org/libc v1.77.1. Onlygo.modandgo.sumchange. Application production-source LOC: +0/-0.Release is deferred until the final Crawlkit
0.16.8consumer bump. This PR does not authorize or publish a release.Evidence
1bb090b38b4cc82c67c01762184b2a97455e58d0; head:f3cd86a42a35c65d6e3b29d56bb30e5652f9d64b.b122d0417c01508beb55158faedeb64a0c5bfd8a, published2026-09-29T08:41:38Z, and libc source9176651b0b6d3fb661a848553e5d608e47e2285eagainst the Go module cache and live upstream sqlite tag.go.modis byte-identical across the two versions: Go >=1.26, libc exactly 1.77.1. Local effective Go and CI'sgo-version-fileselect 1.27.1.GOWORK=off go get modernc.org/sqlite@v1.60.1followed bygo mod tidy: only sqlite changes ingo list -m all;go mod graphis identical after normalizing the sqlite version label. No transitive upgrades. Only the two sqlite checksum records change; the module-file checksum remains identical.GOWORK=off go mod tidy: no further diff.GOWORK=off go mod verify: passed (1.88s).git diff --check: passed..agents/skills/autoreview/scripts/autoreview --mode branch --base 1bb090b38b4cc82c67c01762184b2a97455e58d0 --prompt <dependency-contract context>passed in 47.48s using the repo-default Codex reviewer at high reasoning; no actionable findings.GOWORK=off go test ./internal/store ./internal/portable ./internal/headlinemetrics ./internal/cli -count=1: passed (136.73s). Covers live-WAL online backup and cancellation cleanup, portable export/clone/refresh, open/migrations/read-only, and metrics writer serialization with concurrent readers. No tests added or changed.make checkgates: all passed. InitialGOWORK=off make checkcompleted tidy-check, then detected hostgofmt1.26.4 formatting drift in unchanged source. Prepended$(go env GOROOT)/binand CI-pinned GoReleaser 2.18.2 to PATH;GOWORK=off make -o tidy-check checkresumed the remaining gates without rerunning tidy (163.24s). Formatting, vet, vulnerability scan (none found), deadcode, full-suite atomic coverage (85.6%, floor 85%), build/CLI smoke, release-script fixtures, docs tests/link validation, and six-platformgoreleaser release --snapshot --clean --skip=publishall passed. No unrelated source edits.