Add assistant listen controls to Voice & Audio#800
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 26, 2026, 1:21 AM ET / 05:21 UTC. Summary Reproducibility: not applicable. for the central feature request; this PR adds a new Voice & Audio Assistant surface rather than fixing a reproduced bug. Source inspection verifies the changed paths, but real behavior proof for the runtime flow is still missing. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land a reviewed version after redacted real behavior proof is posted and maintainers explicitly accept the backend resolver and Assistant card as the intended Companion UX. Do we have a high-confidence way to reproduce the issue? Not applicable for the central feature request; this PR adds a new Voice & Audio Assistant surface rather than fixing a reproduced bug. Source inspection verifies the changed paths, but real behavior proof for the runtime flow is still missing. Is this the best way to solve the issue? Mostly yes: the latest patch uses the existing Voice & Audio page, local listen-service bridge, resource-backed strings, and tests for the repaired backend defaults. It is not yet the best shippable path until proof and maintainer acceptance of the backend resolver are covered. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against cd02defd9942. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Maintainer fix pushed for the two review blockers: the Assistant Start path now defaults to local routing (no --allow-cloud) and timed-out backend commands kill/drain the process tree.\n\nLocal validation completed: .\build.ps1, shared tests, tray tests, focused AssistantBridgeService tests, focused security review, and autoreview all passed. I requested @clawsweeper re-review, but the fresh verdict has not landed yet. Holding this unmerged until ClawSweeper/proof catches up or a maintainer explicitly accepts the remaining proof gap. |
Remove the cloud-enabled start flag from the Voice & Audio assistant path, align the UI copy with the local routing default, and kill/drain backend commands that exceed the bridge timeout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
53e3e3a to
caf90c2
Compare
Adds a native Companion GUI surface for the OpenClaw assistant MVP on the existing Voice & Audio page.
Changes:
Validation:
Notes: