Add safe session actions and checkpoint controls#873
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 27, 2026, 3:56 AM ET / 07:56 UTC. Summary Reproducibility: not applicable. as a feature PR. Source inspection confirms current main lacks the new Sessions page Checkpoints and Export transcript actions, and the PR adds them. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land after a maintainer accepts the session-state UX and the PR includes redacted current-head proof for export, checkpoint list or unsupported handling, and blocked destructive main-session actions. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature PR. Source inspection confirms current main lacks the new Sessions page Checkpoints and Export transcript actions, and the PR adds them. Is this the best way to solve the issue? Mostly yes: centralizing destructive session policy in shared helpers is the maintainable direction. It is not the best landing shape until maintainers have inspectable current-head proof for the session-state UX. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against d6b1a72f6d23. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
8db2360 to
065edf7
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Adds confirmed session lifecycle actions, transcript export, and compaction checkpoint controls to the Sessions page. Centralizes session action policy in shared helpers, blocks destructive main-session actions, and hardens checkpoint restore against stale or ambiguous targets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add x:Uid resource coverage for the new Checkpoints and Export transcript menu items across supported locales. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Treat a newest checkpoint without an ID as unsafe for destructive restore instead of falling back to an older restorable checkpoint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep ID-less compaction checkpoints visible to restore safety checks and cover the real chat.history transcript export path in live gateway protocol tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Prevent ID-less compaction checkpoints from being used as branch targets, and localize the destructive/session-altering confirmation prompts through runtime resources. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
065edf7 to
8ab3476
Compare
Summary
Validation
git diff --check✅./build.ps1✅$env:OPENCLAW_REPO_ROOT='C:\Projects\copilot-worktrees\openclaw-windows-node\bkudiess-super-train'; dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --nologo -v q✅ — 2609 passed, 31 skipped, 2640 total$env:OPENCLAW_REPO_ROOT='C:\Projects\copilot-worktrees\openclaw-windows-node\bkudiess-super-train'; dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --nologo -v q✅ — 1284 passedReal behavior proof
./run-app-local.ps1 -NoBuild -AllowNonMain.Manual verification steps
.txttranscript.ClawSweeper follow-up
SessionActionPlannerand using it from both App/toast actions and Sessions page actions.