Reorganize Settings info and diagnostics#874
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 27, 2026, 4:49 AM ET / 08:49 UTC. Summary Reproducibility: not applicable. as a bug reproduction: this PR is a feature/UX reorg. Source inspection and the supplied screenshot verify the claimed surfaces rather than a failing current-main bug. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land after updating the PR body with current-head visible proof and corrected compatibility text, while keeping Diagnostics visible by default and legacy info/about redirects covered by tests. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: this PR is a feature/UX reorg. Source inspection and the supplied screenshot verify the claimed surfaces rather than a failing current-main bug. Is this the best way to solve the issue? Mostly yes: moving Info content into Settings/About with legacy route redirects is a maintainable path, and the latest commits preserve Diagnostics visibility by default. The remaining issue is proof/body freshness, not a clear code defect. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 989f9ffde2dd. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
300bb48 to
065be13
Compare
f47edba to
f8567ed
Compare
- Move About content into Settings with app and gateway info expanders - Remove the standalone Info page and duplicate Diagnostics reconfigure action - Add App theme setting and user-overridable Diagnostics visibility - Update routing, localization, and contract/round-trip tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep Diagnostics visible when ShowDiagnostics is missing so packaged upgrades preserve the existing support surface; only an explicit user override hides it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When Diagnostics is explicitly hidden, remove its back-stack entries and redirect the current Diagnostics page to Settings so Back cannot reopen the hidden surface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f8567ed to
2ef1920
Compare
Summary
info/aboutroutes by redirecting them to Settings and updates localization/tests.Change Type
Scope
Validation
git diff --check— passed.\build.ps1— passed (Debug, win-arm64; Shared, Cli, WinNodeCli, SetupEngine, WinUI)dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj— passed: 2585 passed, 31 skippeddotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj— passed: 1422 passeddotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --filter "FullyQualifiedName~SettingsRoundTripTests|FullyQualifiedName~DiagnosticsPageContractTests|FullyQualifiedName~LocalizationValidationTests"Real behavior proof
Tested current head
f8567ed0on Windows ARM64 using direct unpackaged WinUI launch.Runtime proof:
Screenshot of Settings → About with the new App info / Gateway info expanders:
Verified behavior:
Rubber-duck review
App.OnSettingsSavedonto the dispatcher-safe UI path.DiagnosticsGate.IsVisiblenull-safe before settings initialization.Security Impact
Compatibility / Migration
AppThemeand nullableShowDiagnostics.AppThemedefaults toSystem.ShowDiagnosticsstaysnulland follows the build default (truein Debug/unpackaged local builds, false for packaged Release unless user overrides in Settings).