Calling correct functions according to proper types#481
Open
TLCFEM wants to merge 2 commits intoopencollab:masterfrom
Open
Calling correct functions according to proper types#481TLCFEM wants to merge 2 commits intoopencollab:masterfrom
TLCFEM wants to merge 2 commits intoopencollab:masterfrom
Conversation
Collaborator
|
Not sure about your fix. Can you detail it? |
TLCFEM
commented
Apr 9, 2026
| if (msglvl .gt. 1) then | ||
| call pivout (comm, logfil, 1, [j], ndigit, | ||
| & '_naitr: generating Arnoldi vector number') | ||
| call pzvout (comm, logfil, 1, [rnorm], ndigit, |
Contributor
Author
There was a problem hiding this comment.
rnorm is declared as a double, pzvout expects a complex*16.
TLCFEM
commented
Apr 9, 2026
| if (msglvl .gt. 1) then | ||
| call pivout (comm, logfil, 1, [j], ndigit, | ||
| & '_naitr: generating Arnoldi vector number') | ||
| call pdvout (comm, logfil, 1, [rnorm], ndigit, |
Contributor
Author
There was a problem hiding this comment.
rnorm is declared as a float, pdvout expects a double.
TLCFEM
commented
Apr 9, 2026
| if (msglvl .gt. 1) then | ||
| call pivout (comm, logfil, 1, [j], ndigit, | ||
| & '_naitr: generating Arnoldi vector number') | ||
| call pcvout (comm, logfil, 1, [rnorm], ndigit, |
Contributor
Author
There was a problem hiding this comment.
rnorm is declared as a float, pcvout expects a complex*8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect types would compile just fine but may result in errors when LTO is enabled.
The following is a typical one.