Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates libOpenCOR to version 0.20260420.0 and simplifies third-party header handling by relying on CMake SYSTEM include directories instead of local diagnostic wrapper headers.
Changes:
- Bump project version to
0.20260420.0. - Remove usage (and delete) the
*begin.h/*end.hwrapper headers for LLVM/Clang, SUNDIALS, libSEDML, and libCOMBINE. - Mark third-party include directories as
SYSTEMin CMake to suppress external warnings.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/version.cpp |
Drops LLVM/Clang wrapper includes and adjusts third-party include ordering. |
src/support/sedml/sedmlfile.cpp |
Removes libSEDML wrapper includes around SED-ML headers. |
src/support/combine/combinearchive.cpp |
Removes libCOMBINE wrapper includes around OMEX/COMBINE headers. |
src/solver/solverodefixedstep.cpp |
Removes libSEDML wrapper includes around SED-ML algorithm header. |
src/solver/solverkinsol.cpp |
Removes libSEDML/SUNDIALS wrappers and reorders includes. |
src/solver/solvercvode_p.h |
Removes SUNDIALS wrapper includes. |
src/solver/solvercvode.cpp |
Removes libSEDML/SUNDIALS wrappers and reorders includes. |
src/misc/compiler_p.h |
Removes LLVM wrapper includes. |
src/misc/compiler.cpp |
Removes Clang/LLVM wrapper includes. |
src/3rdparty/libSEDML/libsedmlbegin.h |
Deleted wrapper header. |
src/3rdparty/libSEDML/libsedmlend.h |
Deleted wrapper header. |
src/3rdparty/libCOMBINE/libcombinebegin.h |
Deleted wrapper header. |
src/3rdparty/libCOMBINE/libcombineend.h |
Deleted wrapper header. |
src/3rdparty/SUNDIALS/sundialsbegin.h |
Deleted wrapper header. |
src/3rdparty/SUNDIALS/sundialsend.h |
Deleted wrapper header. |
src/3rdparty/LLVMClang/llvmbegin.h |
Deleted wrapper header. |
src/3rdparty/LLVMClang/llvmend.h |
Deleted wrapper header. |
src/3rdparty/LLVMClang/clangbegin.h |
Deleted wrapper header. |
src/3rdparty/LLVMClang/clangend.h |
Deleted wrapper header. |
cmake/common.cmake |
Marks package include dirs as SYSTEM to suppress third-party warnings. |
VERSION.txt |
Updates the version string to 0.20260420.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.