Merged
Conversation
We don't want our UI JSON file to have an entry for `output.externalData`, so that we can confirm that the entry gets created before adding items to it.
There was a problem hiding this comment.
Pull request overview
This PR bumps the app version to 0.20260416.3, updates Electron to ^41.2.1, and fixes a UI JSON mutation path so external CSV data is reliably appended even when output.externalData is initially absent.
Changes:
- Ensure
interactiveUiJson.value.output.externalDatais initialized before pushing new external data entries. - Bump root + renderer package versions to
0.20260416.3and update Electron dependency/lockfile to^41.2.1. - Add a new OMEX fixture (
tt04_for_external_data.omex) undertests/models/ui/.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/models/ui/tt04_for_external_data.omex | Adds an OMEX fixture used for external-data scenarios. |
| src/renderer/src/components/views/SimulationExperimentView.vue | Fixes external-data insertion by initializing output.externalData before push(). |
| src/renderer/package.json | Bumps renderer version to 0.20260416.3. |
| package.json | Bumps root version to 0.20260416.3 and updates Electron to ^41.2.1. |
| bun.lock | Updates lock entries to match Electron 41.2.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.