Skip to content

Conversation

@welteki
Copy link
Member

@welteki welteki commented May 20, 2025

Description

Fixes for install.sh:

  • Removes the check-update command. This comand is not required and caused the script to exit early if packages are not up to date.
  • DNF is now used to install packages. DNF is the successor of YUM on the latest RHEL-based systems.

Improvements for install-edge.sh:

  • Don't install weak dependencies.

Motivation and Context

  • I have raised an issue to propose this change this is required

Fix install.sh script for RHEL-based systems.

How Has This Been Tested?

Both install.sh and install-edge.sh have been tested on Rocky Linux 9.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

  • I've read the CONTRIBUTION guide
  • My commit message has a body and describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Docs:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

welteki added 2 commits May 20, 2025 17:51
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
This change removes the check-update command. This command is not
required and caused the script to exit early if packages are not up to
date.

In addition DNF is now used to install packages. DNF is the successor of
YUM on the latest RHEL-based system.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
@alexellis alexellis merged commit 83e8045 into openfaas:master May 20, 2025
1 check passed
@alexellis
Copy link
Member

I didn't see the explicit dependencies mentioned that were needed for minimal RHEL-like OSes?

@alexellis
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants