8372745: [lworld] Fatal error in native method when running java/foreign/sharedclosejvmti/TestSharedCloseJvmti.java with --enable-preview

[Arraying]

Hi all,

The test no longer fails with --enable-preview, this PR removes it from the problem list.

Testing: running the test locally 100x and 20x on Linux (x64, AArch64), macOS (AArch64, x64), Windows (x64).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8372745: [lworld] Fatal error in native method when running java/foreign/sharedclosejvmti/TestSharedCloseJvmti.java with --enable-preview (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)
• Lois Foltan (@lfoltan - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2000/head:pull/2000
$ git checkout pull/2000

Update a local copy of the PR:
$ git checkout pull/2000
$ git pull https://git.openjdk.org/valhalla.git pull/2000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2000

View PR using the GUI difftool:
$ git pr show -t 2000

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2000.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372745: [lworld] Fatal error in native method when running java/foreign/sharedclosejvmti/TestSharedCloseJvmti.java with --enable-preview

Reviewed-by: liach, lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

• c5c1002: 8376532: [lworld] Size of BUFFERED layout is sometimes smaller than size of NULLABLE_NON_ATOMIC_FLAT layout
• c2a45c1: 8376818: [lworld] ProblemList compiler/valhalla/inlinetypes/TestTrivialMethods.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (cf999286)

[liach]

Interesting, I know Jorn updated it a while ago, never knew why it would fail in the first place.

[lfoltan]

Looks good, thank you for looking at this.
Lois

[Arraying]

Thanks for the reviews Chen and Lois! I think indeed it might have been something upstream.
/integrate

[openjdk]

Going to push as commit d82abf0.
Since your change was applied there have been 8 commits pushed to the lworld branch:

• 0afc29a: 8376815: [lworld] compiler/valhalla/inlinetypes/TestTrivialMethods.java still fails after JDK-8373692
• 5499e87: 8376752: [lworld] clarify/organize Valhalla ProblemLists
• c498cc6: 8376528: [lworld] value class creation in CompileJavaModules.gmk leaves unnecessary files
• ... and 5 more: https://git.openjdk.org/valhalla/compare/09b557cceafeedcdf1933ef27bb33a6cb1f0069a...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@Arraying Pushed as commit d82abf0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.