[ENH] improved simple assertion error message in evalutation/functions.py
#1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
- Coverage 53.02% 51.96% -1.07%
==========================================
Files 36 36
Lines 4326 4326
==========================================
- Hits 2294 2248 -46
- Misses 2032 2078 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fkiraly
changed the title
evalutation/functions.py
geetu040
suggested changes
Jan 12, 2026
Comment on lines
234
to
236
| assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), type( | ||
| evals_dict["oml:evaluations"], | ||
| evals_dict["oml:evaluations"]["oml:evaluation"], | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Not sure I got what you mean, should I change something or not?
Contributor
There was a problem hiding this comment.
assertion message can be improved like this:
"Expected 'oml:evaluations.oml:evaluation' to be a list, but got ..."
Contributor
Author
It's not. It's a slight mistake I found while reading the code for evaluation functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
fixed a simple assertion error message in `evalutation/functions.py'