feat(web): persist language preference - #359
Open
seekskyworld wants to merge 1 commit into
Open
Conversation
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Implements the language-preference slice of #350. The Web workbench selected a locale only from the browser and lost the choice on reload.
Value
Users can keep a deliberate English/Chinese preference across reloads without involving Session or credential storage.
Approach
Read a validated
openpi.languagevalue from browser-local storage, fall back to navigator detection, and add an accessible language toggle. Invalid values are ignored and storage failures degrade to in-memory behavior.Validation
npx tsc --noEmitnode --test --experimental-strip-types tests/web/app-render.test.tsgit diff --checkImpact