IRIS: site_coords southern-latitude fold uses lon instead of lat

[aladinor]

Summary

IrisStore.site_coords folds southern-hemisphere latitudes using lon instead of lat (iris.py, main, ~line 3737):

lon = lon if lon <= 180 else lon - 360
# todo: is this correct for southern latitudes?
lat = lat if lat <= 180 else lon - 360   # <-- lon, should be lat

Any Sigmet site with BIN4 latitude > 180 (southern hemisphere) reports latitude == longitude - 360. The adjacent # todo suggests the line was already under suspicion.

Expected

lat = lat if lat <= 180 else lat - 360

xradar 0.12.1.dev9+gd723857f2 (main).

[kmuehlbauer]

OK, looking at this, the lon should be lat, indeed. But I think this was a typo I introduced via copy/paste. IIRC my comment was referring to is that for longitudes we have 360deg which get's fixed into [-180, 180]. But is it really true for latitudes to have a range of [-180, 180]?