Fix BatchQuery task mixin and add job/task actions documentation#337
Fix BatchQuery task mixin and add job/task actions documentation#337samuelvkwong wants to merge 10 commits intomainfrom
Conversation
Adds DicomTaskForceRetryView (staff-only) that inherits from DicomTaskResetView but skips the is_resettable check. This allows admins to retry tasks erroneously marked as SUCCESS (e.g. when dcm2niix silently produced 0-byte files during a disk-full event). Added to all four apps: mass_transfer, batch_transfer, batch_query, and selective_transfer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the PENDING/IN_PROGRESS guard — staff can force retry any task, including stuck in-progress or already-pending tasks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ob/task actions - Fix BatchQueryTaskDeleteView, BatchQueryTaskResetView, BatchQueryTaskForceRetryView, and BatchQueryTaskKillView to use BatchQueryLockedMixin instead of SelectiveTransferLockedMixin, so they are gated by the batch query section's lock setting instead of the selective transfer section's - Remove unused SelectiveTransferLockedMixin import from batch_query/views.py - Document job and task statuses, actions, preconditions, permissions, and effects in AGENTS.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Force Retry feature is redundant — the existing Reset (for terminal tasks) and Kill + Reset (for stuck in-progress tasks) already cover all use cases. Removed from: core views/template, batch_transfer, batch_query, mass_transfer, selective_transfer (views, urls, templatetags, tests). Also fixes BatchQuery task views to use BatchQueryLockedMixin instead of SelectiveTransferLockedMixin (pre-existing bug). Added job/task action documentation to AGENTS.md covering all statuses, actions, preconditions, permissions, and state effects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive documentation for job and task management, detailing statuses and available actions in both AGENTS.md and the user guide. Additionally, it refactors the BatchQueryTask views to use the appropriate BatchQueryLockedMixin. The review feedback points out necessary corrections to the documented job status evaluation logic, specifically regarding the CANCELING state, and suggests improving the user guide's clarity on terminal states.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 12 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
BatchQueryLockedMixininstead ofSelectiveTransferLockedMixin. The task action views (Delete, Reset, Kill) were incorrectly gated by the selective transfer section's lock setting instead of the batch query section's.Test plan
🤖 Generated with Claude Code