feat(jira): add risk type to /jira:create skill - #687
Merged
openshift-merge-bot[bot] merged 4 commits intoAug 14, 2026
Merged
openshift-merge-bot[bot] merged 4 commits into
openshift-merge-bot[bot] merged 4 commits into
Conversation
openshift-ci
Bot
added
the
needs-rebase
openshift-ci
Bot
added
the
approved
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe Jira plugin now supports Risk issue creation. It adds Risk guidance and templates, accepts ChangesJira Risk Creation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5 | ❌ 5❌ Failed checks (5 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 14 UNAVAILABLE: read ECONNRESET Comment |
3 tasks
katherinekeane
marked this pull request as draft
August 10, 2026 11:46
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/jira/reference/create-risk.md`:
- Around line 84-88: Update the fallback issue-type list in the qualifying check
to remove Spike, since the create workflow does not support it; retain only
supported types such as Story, Task, or Epic.
- Around line 28-30: Update the fenced code block containing the risk summary
pattern to specify the text language tag, preserving its existing content and
closing fence.
- Around line 148-156: Update the footer in the risk template to italicize only
the “Originally raised” and “Raised by” labels, matching the other labeled
fields. Replace the date and reporter placeholders with explicit instructions
requiring the actual creation date and reporter display name before creating the
issue.
In `@plugins/jira/skills/create/SKILL.md`:
- Around line 31-34: Update the missing-project validation error in the
jira:create skill to include risk alongside the existing bug and feature-request
exceptions, while preserving the current project-key requirement behavior for
all other types.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c89180e6-01ab-43a8-8b64-d562887f67cf
📒 Files selected for processing (4)
.claude-plugin/marketplace.jsonplugins/jira/.claude-plugin/plugin.jsonplugins/jira/reference/create-risk.mdplugins/jira/skills/create/SKILL.md
Comment on lines
+148
to
+156
| _What could go wrong:_ <Describe the risk event in detail> | ||
|
|
||
| _What triggers it:_ <Conditions or events that would cause the risk to materialize> | ||
|
|
||
| _What would be affected:_ <Teams, services, milestones, or customers impacted> | ||
|
|
||
| _Mitigation/contingency plan:_ <Actions to reduce probability or impact; how to respond if it materializes. Omit this line if not yet assessed.> | ||
|
|
||
| _Originally raised: YYYY-MM-DD. Raised by: <reporter display name>._ |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Match the footer to the italic-label format.
Lines 148-154 italicize only each label. Line 156 italicizes the entire footer and leaves two placeholders without an explicit substitution rule. Use separate label spans and require the actual creation date and reporter display name before issue creation.
Proposed fix
-_Originally raised: YYYY-MM-DD. Raised by: <reporter display name>._
+_Originally raised:_ YYYY-MM-DD. _Raised by:_ <reporter display name>.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/jira/reference/create-risk.md` around lines 148 - 156, Update the
footer in the risk template to italicize only the “Originally raised” and
“Raised by” labels, matching the other labeled fields. Replace the date and
reporter placeholders with explicit instructions requiring the actual creation
date and reporter display name before creating the issue.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/jira/reference/gcp-hcp.md`:
- Line 165: Update the Jira risk template reference in gcp-hcp.md to point to an
existing canonical upstream source, or add the missing
docs/jira-risk-template.md file in the upstream repository and keep the
reference valid; ensure both references are consistent and resolve successfully.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 456e7813-a9db-498e-b36c-a535a17bf2cb
📒 Files selected for processing (1)
plugins/jira/reference/gcp-hcp.md
|
|
||
| ### Risk Template | ||
|
|
||
| Source: [jira-risk-template.md](https://github.com/openshift-online/gcp-hcp/blob/main/docs/jira-risk-template.md) |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -u
printf '%s\n' '--- local references ---'
cat -n plugins/jira/reference/gcp-hcp.md | sed -n '158,238p'
printf '%s\n' '--- direct upstream URL ---'
curl -L -sS -o /tmp/jira-risk-template.body -D /tmp/jira-risk-template.headers \
-w 'http_status=%{http_code}\nfinal_url=%{url_effective}\n' \
'https://github.com/openshift-online/gcp-hcp/blob/main/docs/jira-risk-template.md'
sed -n '1,20p' /tmp/jira-risk-template.headers
printf 'body_bytes='
wc -c < /tmp/jira-risk-template.body
printf '%s\n' '--- repository tree candidates ---'
curl -L -sS 'https://api.github.com/repos/openshift-online/gcp-hcp/git/trees/main?recursive=1' |
jq -r '.tree[]?.path' |
rg -i 'jira|risk|template' || trueRepository: openshift-eng/ai-helpers
Length of output: 10957
Fix the upstream Risk template references.
The upstream repository has no docs/jira-risk-template.md. Add the file, or update both references to an existing canonical source.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/jira/reference/gcp-hcp.md` at line 165, Update the Jira risk template
reference in gcp-hcp.md to point to an existing canonical upstream source, or
add the missing docs/jira-risk-template.md file in the upstream repository and
keep the reference valid; ensure both references are consistent and resolve
successfully.
Source: MCP tools
katherinekeane
marked this pull request as ready for review
August 10, 2026 15:25
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
3 tasks
Adds `risk` as a supported issue type in the /jira:create skill: - `plugins/jira/reference/create-risk.md`: new type-specific guidance with qualifying criteria, summary pattern, probability/impact tables, auto-calculated field warnings, 9-step interactive workflow (including component and assignee prompts), and description template matching the team's italic-label format. - `plugins/jira/skills/create/SKILL.md`: adds `risk` to the type routing table, arguments list, error messages, and usage examples. - Bumps plugin version 0.9.0 → 0.9.2. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds Risk Template section to gcp-hcp.md with summary format, description format (italic inline labels), required field IDs, and link to risk-tracking-process.md. Also adds jira-risk-template.md to the upstream sources table. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
katherinekeane
force-pushed
the
feat/jira-risk-type
branch
from
August 11, 2026 11:13
d2b74e5 to
dd61650
Compare
openshift-ci
Bot
removed
the
needs-rebase
Score is calculated by ScriptRunner with non-linear impact weights (range 1-250), not a simple Probability × Impact multiplication. Aligns with updated risk-tracking-process.md. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add language tag to summary pattern code block - Add risks to missing-project-key error message Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
adamminter
added a commit
to adamminter/ai-helpers
that referenced
this pull request
Aug 14, 2026
- Add /jira:create to When to Use section
- Fix Activity Type format to {"value": "..."} in ROSAENG custom fields table
- Add Risk pointer to openshift-eng#687 since risk conventions are deferred
- Add Maintenance section with upstream source links for team directory updates
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@apahim: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adamminter, apahim, katherinekeane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
riskas a supported issue type in the/jira:createskillreference/create-risk.mdwith 9-step interactive workflow: qualifying criteria, summary pattern, probability/impact assessment (option IDs fetched at runtime), component, assignee, optional mitigation plan, and optional fields_What could go wrong:_etc.) with an_Originally raised:_footer — validated against existing GCP Risk issuesSKILL.mdupdated: type routing table, arguments list, error messages, usage examplecustomfield_10976) and Risk Score Assessment (customfield_10974) explicitly excluded — ScriptRunner auto-calculates both from Probability × ImpactTest plan
/jira:create risk GCPand verify qualifying check redirects non-risks to appropriate typegetJiraIssueTypeMetaWithFieldsai-generated-jiralabel and description in italic-label format🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores