fix(api-server): default DB secret paths to in-pod mount location - #446
Open
bsquizz wants to merge 2 commits into
Open
fix(api-server): default DB secret paths to in-pod mount location#446bsquizz wants to merge 2 commits into
bsquizz wants to merge 2 commits into
Conversation
|
🤖 Amber Review Fixes incorrect DB secret file paths: upstream Findings:
Correct, DRY improvement. No security surface touched, no tokens involved. Logic is trivially verifiable by inspection. Confidence: High — Amber, ACP codebase intelligence |
bsquizz
force-pushed
the
fix/seed-admin-db-defaults
branch
from
August 3, 2026 14:24
adb12b0 to
abcb512
Compare
The seed-admin and encrypt-credentials subcommands inherit upstream rh-trex-ai defaults (secrets/db.host) which don't match the API server pod's volume mount at /secrets/db/db.host. This forced every caller to pass explicit --db-*-file flags. Extract a shared setInPodDBDefaults helper that overrides the defaults to /secrets/db/db.*, and remove the now-redundant flags from the bootstrap-admin Job manifest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies all five DB secret file path overrides to catch silent regressions if the mount paths change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bsquizz
force-pushed
the
fix/seed-admin-db-defaults
branch
from
August 3, 2026 14:25
abcb512 to
109cac9
Compare
bsquizz
marked this pull request as ready for review
August 3, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seed-adminandencrypt-credentialssubcommands inherit upstream rh-trex-ai defaults (secrets/db.host) which don't match the API server pod's volume mount at/secrets/db/db.host, requiring every caller to pass explicit--db-*-fileflagssetInPodDBDefaultshelper that overrides the defaults to/secrets/db/db.*--db-*-fileflags from the bootstrap-admin Job manifestSpec impact
None — no specs reference
seed-admin, the bootstrap job, or DB secret paths.Test plan
kubectl execinto API server pod and runseed-admin --username testwithout--db-*-fileflags — should connect to DB successfullygo build ./...passes incomponents/ambient-api-server/🤖 Generated with Claude Code