Skip to content

chore(tekton): remove credential sidecar Konflux builds - #469

Open
squizzi wants to merge 2 commits into
mainfrom
squizzi/remove-credential-sidecar-builds
Open

chore(tekton): remove credential sidecar Konflux builds#469
squizzi wants to merge 2 commits into
mainfrom
squizzi/remove-credential-sidecar-builds

Conversation

@squizzi

@squizzi squizzi commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Credential sidecars have been fully replaced by the OpenShell provider model. This PR removes the 8 Tekton pipeline files that were still building unused credential sidecar images (github, google, jira, k8s) in Konflux on every push to main, and updates 5 spec files to reflect the deprecation. Net deletion of ~4,400 lines of unused pipeline YAML.

Ref: ENGPROD-10268

Test plan

  • Verify no Konflux pipeline runs trigger for credential sidecar images after merge
  • Confirm remaining .tekton/ pipelines still build correctly

@jsell-rh jsell-rh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Amber Analysis — PR #469: chore(tekton): remove credential sidecar Konflux builds

Clean, well-scoped cleanup. Removing 8 defunct Tekton pipeline files and updating 5 spec files to reflect the completed migration to the OpenShell provider model.

What I checked:

  • 8 Tekton pipeline files — pure deletions (~4,400 lines), no code changes. ENGPROD-10268 referenced. All four credential sidecar images (github, google, jira, k8s) covered.
  • 5 spec files — accurate and consistent with the architectural migration. credential-binding.spec.md and identity-boundaries.spec.md correctly mark the sidecar entrypoint as removed; openshell-sandbox-provisioning.spec.md reflects the provider-model as the sole injection mechanism.
  • No Go, TypeScript, or production code changes — pure CI pipeline removal + doc updates.

No findings. The changes are well-explained, net-negative (4,400 lines removed), and consistent with the direction established in specs/platform/openshell-sandbox-provisioning.spec.md.

Note: PR is currently in Draft state — flagging in case that wasn't intentional.

Confidence: [95%] High — purely additive deletions with accurate spec documentation.


— Amber

squizzi added a commit that referenced this pull request Jul 31, 2026
- MCP server image SHALL NOT be deployed (openshell provider handles
  MCP via provider model), replacing ambiguous MAY language
- Align index entry abbreviations with established style (CP, CI/CD)

Credential sidecar pipeline removal tracked separately in #469.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
squizzi added a commit that referenced this pull request Jul 31, 2026
These are handled by #469 — the spec just deploys whatever images
Konflux builds from main.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
@JGiola

JGiola commented Aug 3, 2026

Copy link
Copy Markdown

For this we can also remove the relevant files in the konflux-release-data repository. We only have to choose if remove everything (and delete all the images in quay) or add the image-controller.appstudio.redhat.com/skip-repository-deletion: "true" annotation to the ImageRepository in an MR, merge that and then create the MR for deleting the resources (this will delete all the konflux resources but will keep the images uploaded to quay).

squizzi and others added 2 commits August 3, 2026 06:54
Credential sidecars have been fully replaced by the OpenShell provider
model. Remove the 8 Tekton pipeline files that were still building
unused credential sidecar images (github, google, jira, k8s) on every
push to main. Update specs to reflect the deprecation.

Ref: ENGPROD-10268

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
The ambient-mcp sidecar is disabled in the reconciler — gateway handles
MCP now. Remove the Tekton pipelines that were still building the unused
acp_mcp image in Konflux on every push to main.

Ref: ENGPROD-10268

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
@squizzi
squizzi force-pushed the squizzi/remove-credential-sidecar-builds branch from a0b8578 to 0aeb422 Compare August 3, 2026 13:54
@squizzi

squizzi commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

image-controller.appstudio.redhat.com/skip-repository-deletion: "true" annotation to the ImageRepository in an MR

I don't think we need to keep these around, I don't really see the value in retaining them, we're going to remove the credential sidecar code eventually it's just out of scope for this specific PR.

squizzi added a commit that referenced this pull request Aug 3, 2026
- MCP server image SHALL NOT be deployed (openshell provider handles
  MCP via provider model), replacing ambiguous MAY language
- Align index entry abbreviations with established style (CP, CI/CD)

Credential sidecar pipeline removal tracked separately in #469.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
squizzi added a commit that referenced this pull request Aug 3, 2026
These are handled by #469 — the spec just deploys whatever images
Konflux builds from main.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
@squizzi
squizzi marked this pull request as ready for review August 3, 2026 15:49
@github-actions github-actions Bot added the auto-merge-pending PR eligible for auto-merge, waiting for checks label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amber/approved auto-merge-pending PR eligible for auto-merge, waiting for checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants