chore(tekton): remove credential sidecar Konflux builds - #469
Conversation
jsell-rh
left a comment
There was a problem hiding this comment.
🤖 Amber Analysis — PR #469: chore(tekton): remove credential sidecar Konflux builds
Clean, well-scoped cleanup. Removing 8 defunct Tekton pipeline files and updating 5 spec files to reflect the completed migration to the OpenShell provider model.
What I checked:
- 8 Tekton pipeline files — pure deletions (~4,400 lines), no code changes. ENGPROD-10268 referenced. All four credential sidecar images (github, google, jira, k8s) covered.
- 5 spec files — accurate and consistent with the architectural migration.
credential-binding.spec.mdandidentity-boundaries.spec.mdcorrectly mark the sidecar entrypoint as removed;openshell-sandbox-provisioning.spec.mdreflects the provider-model as the sole injection mechanism. - No Go, TypeScript, or production code changes — pure CI pipeline removal + doc updates.
No findings. The changes are well-explained, net-negative (4,400 lines removed), and consistent with the direction established in specs/platform/openshell-sandbox-provisioning.spec.md.
Note: PR is currently in Draft state — flagging in case that wasn't intentional.
Confidence: [95%] High — purely additive deletions with accurate spec documentation.
— Amber
- MCP server image SHALL NOT be deployed (openshell provider handles MCP via provider model), replacing ambiguous MAY language - Align index entry abbreviations with established style (CP, CI/CD) Credential sidecar pipeline removal tracked separately in #469. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
These are handled by #469 — the spec just deploys whatever images Konflux builds from main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
|
For this we can also remove the relevant files in the konflux-release-data repository. We only have to choose if remove everything (and delete all the images in quay) or add the |
Credential sidecars have been fully replaced by the OpenShell provider model. Remove the 8 Tekton pipeline files that were still building unused credential sidecar images (github, google, jira, k8s) on every push to main. Update specs to reflect the deprecation. Ref: ENGPROD-10268 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
The ambient-mcp sidecar is disabled in the reconciler — gateway handles MCP now. Remove the Tekton pipelines that were still building the unused acp_mcp image in Konflux on every push to main. Ref: ENGPROD-10268 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
a0b8578 to
0aeb422
Compare
I don't think we need to keep these around, I don't really see the value in retaining them, we're going to remove the credential sidecar code eventually it's just out of scope for this specific PR. |
- MCP server image SHALL NOT be deployed (openshell provider handles MCP via provider model), replacing ambiguous MAY language - Align index entry abbreviations with established style (CP, CI/CD) Credential sidecar pipeline removal tracked separately in #469. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
These are handled by #469 — the spec just deploys whatever images Konflux builds from main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
Summary
Credential sidecars have been fully replaced by the OpenShell provider model. This PR removes the 8 Tekton pipeline files that were still building unused credential sidecar images (github, google, jira, k8s) in Konflux on every push to main, and updates 5 spec files to reflect the deprecation. Net deletion of ~4,400 lines of unused pipeline YAML.
Ref: ENGPROD-10268
Test plan
.tekton/pipelines still build correctly