Skip to content

WIP: [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmanzari wants to merge 1 commit into
base: main
Choose a base branch
from
+73 −0
Open

WIP: [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions .tekton/ove-ui-iso-prow-job-4.22.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
name: abi-ove-konflux-prow-integration
spec:
description: >-
Run OVE+CNV validation 4.22 Prow job
params:
- name: GANGWAY_TOKEN
type: string
description: Token to authenticate with gangway
default: gangway-token
- description: 'Snapshot of the application'
name: SNAPSHOT
default: '{"components": [{"name":"installer-ove-ui-4-22-art-agent-installer-iso", "containerImage": "quay.io/redhat-user-workloads/ocp-art-tenant/art-agent-installer-iso@sha256:9c753c6a05bdc15269793e96d37735ebfe6f0d74d35bfc2c87cd1967891e9c34"}]}'
type: string
tasks:
- name: get-catalog-image
params:
- name: SNAPSHOT
value: $(params.SNAPSHOT)
taskSpec:
params:
- name: SNAPSHOT
results:
- name: CATALOG_IMAGE
description: "The catalog image extracted from the SNAPSHOT"
steps:
- name: get-catalog-image
image: registry.redhat.io/openshift4/ose-cli:latest
env:
- name: SNAPSHOT
value: $(params.SNAPSHOT)
script: |
#!/bin/bash
set -e
dnf -y install jq
echo "Snapshot: ${SNAPSHOT}"
catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}")

@coderabbitai coderabbitai Bot Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Update the stale 4.21 component selector.

Line 39 selects ove-ui-iso-4-21, but the 4.22 snapshot declares installer-ove-ui-4-22-art-agent-installer-iso. This writes an empty result and invokes Prow with SNAPSHOT=.

Proposed fix 
-              catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}")
+              catalogImage=$(jq -r '.components[] | select(.name=="installer-ove-ui-4-22-art-agent-installer-iso") | .containerImage' <<< "${SNAPSHOT}")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}")
catalogImage=$(jq -r '.components[] | select(.name=="installer-ove-ui-4-22-art-agent-installer-iso") | .containerImage' <<< "${SNAPSHOT}")
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/ove-ui-iso-prow-job-4.22.yaml at line 39, Update the jq selector in
the snapshot extraction command to select the declared 4.22 component name,
installer-ove-ui-4-22-art-agent-installer-iso, instead of ove-ui-iso-4-21, while
preserving the existing containerImage extraction.

echo "Catalog image: ${catalogImage}"
echo -n "${catalogImage}" > $(results.CATALOG_IMAGE.path)
- name: prowjob-ove422
displayName: "Running prow job $(params.PROWJOB_NAME)"
timeout: "5h"
runAfter:
- get-catalog-image
taskRef:
resolver: git
params:
- name: url
value: https://github.com/openshift/konflux-tasks
- name: revision
value: main
- name: pathInRepo
value: tasks/provide-prowjob/0.1/provide-prowjob.yaml
params:
- name: SNAPSHOT
value: $(params.SNAPSHOT)
- name: PROWJOB_ORG
value: 'openshift-eng'
- name: PROWJOB_REPO
value: 'agent-qe-infra'
- name: VARIANT
value: 'amd64-nightly'
- name: ARTIFACTS_BUILD_ROOT
value: quay-proxy.ci.openshift.org/openshift/ci:openshift_release_rhel-9-release-golang-1.23-openshift-4.22
- name: ENVS
value: 'SNAPSHOT=$(tasks.get-catalog-image.results.CATALOG_IMAGE)'
matrix:
params:
- name: PROWJOB_NAME
value:
- periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-konflux