Skip to content

AGENT-1573: Add release-5.1 config for ISOBuilder #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pawanpinjarkar wants to merge 1 commit into
base: main
Choose a base branch
from
+60 −0
Open

AGENT-1573: Add release-5.1 config for ISOBuilder #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions tools/iso_builder/config/5.1/appliance-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
apiVersion: v1beta1
kind: ApplianceConfig
diskSizeGB: 200
stopLocalRegistry: false
enableDefaultSources: false # Enables all default CatalogSources (on openshift-marketplace namespace). Should be disabled for disconnected environments.
useDefaultSourceNames: true # Renames CatalogSource names generated by oc-mirror to the default naming. E.g. 'redhat-operators' instead of 'cs-redhat-operator-index-v4-19'.
enableInteractiveFlow: true
skipLocalRegistry: true # Required to enable the IRI MCO registry (by disabling the default appliance registry)
imageRegistry:
useBinary: true
additionalImages:
- name: registry.redhat.io/rhel9/support-tools:latest

@coderabbitai coderabbitai Bot Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -eu

printf '%s\n' '--- appliance-config.yaml ---'
cat -n tools/iso_builder/config/5.1/appliance-config.yaml | sed -n '1,80p'

printf '%s\n' '--- related files ---'
fd -t f . tools/iso_builder | sort

printf '%s\n' '--- references to appliance-config and support-tools ---'
rg -n -C 3 'appliance-config|support-tools|registry\.redhat\.io/rhel9' tools README.md .github 2>/dev/null || true

Repository: openshift/agent-installer-utils

Length of output: 9940

🏁 Script executed:

#!/bin/bash
set -eu

printf '%s\n' '--- build script ---'
cat -n tools/iso_builder/hack/build-ove-image.sh | sed -n '1,130p'

printf '%s\n' '--- Dockerfile and README references ---'
cat -n tools/iso_builder/Dockerfile | sed -n '1,70p'
rg -n -C 4 'additionalImages|imageRegistry|support-tools|digest|immutable|pull|appliance' \
  tools/iso_builder/README.md tools/iso_builder/CLAUDE.md tools/iso_builder/hack \
  tools/iso_builder/config 2>/dev/null || true

printf '%s\n' '--- git metadata for target and neighboring configs ---'
git diff --stat
git status --short
git ls-files -s tools/iso_builder/config/5.1/appliance-config.yaml

Repository: openshift/agent-installer-utils

Length of output: 44555

Pin the support-tools image to an immutable reference.

:latest can embed different image content in different ISO builds. Use an approved digest or immutable version tag.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tools/iso_builder/config/5.1/appliance-config.yaml` at line 12, Update the
support-tools image reference in the appliance configuration to replace the
mutable latest tag with an approved immutable digest or version-specific tag,
preserving the existing registry repository.

operators:
- catalog: registry.redhat.io/redhat/redhat-operator-index:v4.22
packages:
- name: kubevirt-hyperconverged
channels:
- name: stable
- name: mtv-operator
channels:
- name: release-v2.12
- name: kubernetes-nmstate-operator
channels:
- name: stable
- name: node-healthcheck-operator
channels:
- name: stable
- name: node-maintenance-operator
channels:
- name: stable
- name: fence-agents-remediation
channels:
- name: stable
- name: cluster-kube-descheduler-operator
channels:
- name: stable
- name: metallb-operator
channels:
- name: stable
- name: cluster-observability-operator
channels:
- name: stable
- name: redhat-oadp-operator
channels:
- name: stable
- name: local-storage-operator
channels:
- name: stable
- name: lvms-operator
channels:
- name: stable-4.22
- name: numaresources-operator
channels:
- name: "4.22"
- name: loki-operator
channels:
- name: stable-6.6
- name: cluster-logging
channels:
- name: stable-6.6