Skip to content

Conversation

@cajieh
Copy link
Contributor

@cajieh cajieh commented Nov 25, 2025

Before:

Screenshot 2025-11-25 at 11 59 56 AM

After:

Screenshot 2025-11-25 at 12 00 03 PM

To reproduce:

apiVersion: v1
kind: Namespace
metadata:
  name: test-breakdown-bug
---
apiVersion: v1
kind: ResourceQuota
metadata:
  name: test-quota
  namespace: test-breakdown-bug
spec:
  hard:
    requests.cpu: "1"
    requests.memory: 2Gi
    limits.cpu: "2"
    limits.memory: 4Gi
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: high-resource-app
  namespace: test-breakdown-bug
spec:
  replicas: 2
  selector:
    matchLabels:
      app: test-app
  template:
    metadata:
      labels:
        app: test-app
    spec:
      containers:
      - name: app
        image: nginxinc/nginx-unprivileged:latest
        resources:
          requests:
            memory: "900Mi"    # High request: 900Mi x 2 = 1.8Gi (90% of 2Gi quota)
            cpu: "450m"        # High request: 450m x 2 = 900m (90% of 1 CPU quota)
          limits:
            memory: "1800Mi"   # High limit: 1.8Gi x 2 = 3.6Gi (90% of 4Gi limit)
            cpu: "950m"        # High limit: 950m x 2 = 1.9 CPU (95% of 2 CPU limit)
        ports:
        - containerPort: 8080

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 25, 2025
@openshift-ci-robot
Copy link
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-64652, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Walkthrough

Removed the "See breakdown" translation entry from most locale JSON files (en, es, fr, ja, ko, zh) and removed the title prop from a PFPopover in NodeAlerts.tsx.

Changes

Cohort / File(s) Summary
Locale — removed translation
frontend/packages/console-app/locales/en/console-app.json, frontend/packages/console-app/locales/es/console-app.json, frontend/packages/console-app/locales/fr/console-app.json, frontend/packages/console-app/locales/ja/console-app.json, frontend/packages/console-app/locales/ko/console-app.json, frontend/packages/console-app/locales/zh/console-app.json
Deleted the "See breakdown" key/value from each listed locale JSON. Some files also adjusted trailing newline handling.
UI component — popover prop removed
frontend/packages/console-app/src/components/nodes/node-dashboard/NodeAlerts.tsx
Removed the title prop from the PFPopover used inside LimitLink. No other logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check whether the removed translation key is referenced elsewhere (code or i18n lookup) to avoid missing-string regressions.
  • Verify UI/UX and accessibility impact of removing the PFPopover title (screen reader behavior, visible tooltip content).
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between c517c52 and be3ea89.

📒 Files selected for processing (7)
  • frontend/packages/console-app/locales/en/console-app.json (0 hunks)
  • frontend/packages/console-app/locales/es/console-app.json (1 hunks)
  • frontend/packages/console-app/locales/fr/console-app.json (1 hunks)
  • frontend/packages/console-app/locales/ja/console-app.json (1 hunks)
  • frontend/packages/console-app/locales/ko/console-app.json (1 hunks)
  • frontend/packages/console-app/locales/zh/console-app.json (1 hunks)
  • frontend/packages/console-app/src/components/nodes/node-dashboard/NodeAlerts.tsx (0 hunks)
💤 Files with no reviewable changes (2)
  • frontend/packages/console-app/locales/en/console-app.json
  • frontend/packages/console-app/src/components/nodes/node-dashboard/NodeAlerts.tsx
🚧 Files skipped from review as they are similar to previous changes (4)
  • frontend/packages/console-app/locales/ja/console-app.json
  • frontend/packages/console-app/locales/zh/console-app.json
  • frontend/packages/console-app/locales/es/console-app.json
  • frontend/packages/console-app/locales/fr/console-app.json
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • frontend/packages/console-app/locales/ko/console-app.json
🔇 Additional comments (1)
frontend/packages/console-app/locales/ko/console-app.json (1)

1-576: Correct and consistent locale update.

The removal of the "See breakdown" translation entry is properly applied and aligns with parallel removals in other locale files as part of the fix for duplicate words in the Console UI. The JSON structure is valid and intact.


Comment @coderabbitai help to get the list of available commands and usage tips.

@cajieh cajieh force-pushed the duplicate-words-onsoleui-ee-breakdown-breakdown branch from c517c52 to be3ea89 Compare November 25, 2025 17:05
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@krishagarwal278
Copy link
Member

QE Approval:
/assign @yapei

@openshift-ci-robot
Copy link
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-64652, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Before:

Screenshot 2025-11-25 at 11 59 56 AM

After:

Screenshot 2025-11-25 at 12 00 03 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, jhadvig, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yapei
Copy link
Contributor

yapei commented Dec 3, 2025

verified the bug fix with following steps

  • cordon all but one all worker
$ oc adm cordon <node_name>
$ oc get node | grep worker
ip-10-0-xxx-xxx.us-east-2.compute.internal    Ready,SchedulingDisabled   worker                 84m    v1.34.2
ip-10-0-xxx-xxx.us-east-2.compute.internal    Ready,SchedulingDisabled   worker                 84m    v1.34.2
ip-10-0-xxx-xxx.us-east-2.compute.internal     Ready                      worker                 84m    v1.34.2
  • Create test deployment with requests and limits settings, scale up more pods as needed if the required alert is not triggered
apiVersion: apps/v1
kind: Deployment
metadata:
  name: high-resource-app
  namespace: test-breakdown-bug
spec:
  replicas: 2
  selector:
    matchLabels:
      app: test-app
  template:
    metadata:
      labels:
        app: test-app
    spec:
      containers:
      - name: app
        image: image-registry.openshift-image-registry.svc:5000/openshift/httpd:latest
        resources:
          requests:
            memory: "900Mi"    # High request: 900Mi x 2 = 1.8Gi (90% of 2Gi quota)
            cpu: "450m"        # High request: 450m x 2 = 900m (90% of 1 CPU quota)
          limits:
            memory: "1800Mi"   # High limit: 1.8Gi x 2 = 3.6Gi (90% of 4Gi limit)
            cpu: "950m"        # High limit: 950m x 2 = 1.9 CPU (95% of 2 CPU limit)
        ports:
        - containerPort: 8080
  • wait for several several minutes, we will see the alert firing and shown on Node Status card
Screenshot 2025-12-03 at 4 16 50 PM Screenshot 2025-12-03 at 4 17 34 PM

/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 3, 2025
@openshift-ci-robot
Copy link
Contributor

@yapei: This PR has been marked as verified by @yapei.

In response to this:

verified the bug fix with following steps

  • cordon all but one all worker
$ oc adm cordon <node_name>
$ oc get node | grep worker
ip-10-0-xxx-xxx.us-east-2.compute.internal    Ready,SchedulingDisabled   worker                 84m    v1.34.2
ip-10-0-xxx-xxx.us-east-2.compute.internal    Ready,SchedulingDisabled   worker                 84m    v1.34.2
ip-10-0-xxx-xxx.us-east-2.compute.internal     Ready                      worker                 84m    v1.34.2
  • Create test deployment with requests and limits settings, scale up more pods as needed if the required alert is not triggered
apiVersion: apps/v1
kind: Deployment
metadata:
 name: high-resource-app
 namespace: test-breakdown-bug
spec:
 replicas: 2
 selector:
   matchLabels:
     app: test-app
 template:
   metadata:
     labels:
       app: test-app
   spec:
     containers:
     - name: app
       image: image-registry.openshift-image-registry.svc:5000/openshift/httpd:latest
       resources:
         requests:
           memory: "900Mi"    # High request: 900Mi x 2 = 1.8Gi (90% of 2Gi quota)
           cpu: "450m"        # High request: 450m x 2 = 900m (90% of 1 CPU quota)
         limits:
           memory: "1800Mi"   # High limit: 1.8Gi x 2 = 3.6Gi (90% of 4Gi limit)
           cpu: "950m"        # High limit: 950m x 2 = 1.9 CPU (95% of 2 CPU limit)
       ports:
       - containerPort: 8080
  • wait for several several minutes, we will see the alert firing and shown on Node Status card
Screenshot 2025-12-03 at 4 16 50 PM Screenshot 2025-12-03 at 4 17 34 PM

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants