Skip to content

[release-4.16] OCPBUGS-99890: Bump ironic-python-agent pinned commit for CVE-2026-66138 - #310

Open
mariocr73 wants to merge 1 commit into
openshift:release-4.16from
mariocr73:OCPBUGS-99890-416
Open

[release-4.16] OCPBUGS-99890: Bump ironic-python-agent pinned commit for CVE-2026-66138#310
mariocr73 wants to merge 1 commit into
openshift:release-4.16from
mariocr73:OCPBUGS-99890-416

Conversation

@mariocr73

@mariocr73 mariocr73 commented Aug 20, 2026

Copy link
Copy Markdown

Bumps the pinned ironic-python-agent commit in requirements.cachito from 25670b09 to 2ce2ec34, which cherry-picks the upstream security fix for CVE-2026-66138 (NTP command injection in sync_clock()) onto the OCP 4.16 branch via openshift/openstack-ironic-python-agent#200.

Note: openshift/openstack-ironic-python-agent#200 is not yet merged at the time this PR was opened (opened intentionally before merge, so both PRs stay linked to the Jira bug simultaneously). ci/prow/check-requirements is expected to fail/wait until #200 merges, at which point the pinned SHA here will be corrected to the real merge commit on release-4.16.

Related: OCPBUGS-99890

Update the pinned ironic-python-agent commit from 25670b09 to 2ce2ec34
(the branch tip of openshift/openstack-ironic-python-agent#200, NOT
YET MERGED at the time of this commit), which cherry-picks upstream
security fix (NTP command injection in sync_clock(), CVE-2026-66138)
onto the OCP 4.16 branch. This PR is opened before openshift#200 merges,
intentionally, to keep both PRs linked to the Jira bug simultaneously
(see LESSONS-LEARNED-OCPBUGS-CVE-FIX.md addendum to section 1) —
ci/prow/check-requirements is expected to fail/wait until openshift#200 merges,
at which point the pinned SHA here must be corrected to the real merge
commit on release-4.16 (see section 11).
Related: OCPBUGS-99890
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mariocr73: This pull request references Jira Issue OCPBUGS-99890, which is invalid:

  • expected dependent Jira Issue OCPBUGS-99886 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bumps the pinned ironic-python-agent commit in requirements.cachito from 25670b09 to 2ce2ec34, which cherry-picks the upstream security fix for CVE-2026-66138 (NTP command injection in sync_clock()) onto the OCP 4.16 branch via openshift/openstack-ironic-python-agent#200.

Note: openshift/openstack-ironic-python-agent#200 is not yet merged at the time this PR was opened (opened intentionally before merge, so both PRs stay linked to the Jira bug simultaneously). ci/prow/check-requirements is expected to fail/wait until #200 merges, at which point the pinned SHA here will be corrected to the real merge commit on release-4.16.

Related: OCPBUGS-99890

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 36cbf1cf-fa1e-4ecc-90eb-257bbf78fb69

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from elfosardo and zaneb August 20, 2026 16:29
@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mariocr73
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkaurredhat

Copy link
Copy Markdown

/lgtm
/label approved

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-metal-ipi-ovn-ipv4
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-serial-ipv4
/test e2e-metal-ipi-virtualmedia

@mariocr73

Copy link
Copy Markdown
Author

/test ci/prow/e2e-metal-ipi-virtualmedia

@mariocr73

Copy link
Copy Markdown
Author

/test e2e-metal-ipi-virtualmedia

@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown

@mariocr73: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check-requirements 6e8f5c2 link true /test check-requirements
ci/prow/e2e-metal-ipi-virtualmedia 6e8f5c2 link true /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants