WIP Hypershift BM - Agent based via Assisted Installer with IP echo server

[asood-rh]

Summary by CodeRabbit

• Adds a scheduled bare-metal HyperShift agent test job for OVN-Kubernetes with Assisted Installer.
• Provisions a Python HTTP IP echo service on the provisioning host and publishes its host IP and URL.
• Adds failure-tolerant cleanup that removes the service, systemd unit, and executable after testing.
• Adds ownership metadata for the new CI step registry components.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f56fb5a9-0dc9-47f7-a314-5c460c711efb

📥 Commits

Reviewing files that changed from the base of the PR and between 7000c1d and baf9ebf.

📒 Files selected for processing (3)

• ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
• ci-operator/step-registry/hypershift/agent/ovn/ipecho/deprovision/hypershift-agent-ovn-ipecho-deprovision-ref.metadata.json
• ci-operator/step-registry/hypershift/agent/ovn/ipecho/provision/hypershift-agent-ovn-ipecho-provision-ref.metadata.json

🚧 Files skipped from review as they are similar to previous changes (3)

• ci-operator/step-registry/hypershift/agent/ovn/ipecho/provision/hypershift-agent-ovn-ipecho-provision-ref.metadata.json
• ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
• ci-operator/step-registry/hypershift/agent/ovn/ipecho/deprovision/hypershift-agent-ovn-ipecho-deprovision-ref.metadata.json

---

Walkthrough

The change adds HyperShift agent OVN ipecho provision and deprovision steps. It also adds a scheduled bare-metal OVN egress-IP debug job that runs provisioning, a wait step, and cleanup.

Changes

HyperShift OVN ipecho debug flow

Layer / File(s)	Summary
Provision the ipecho service ci-operator/step-registry/hypershift/agent/ovn/ipecho/provision/*	Adds a systemd Python HTTP ipecho service, readiness checks, shared output files, step configuration, metadata, and ownership.
Run the scheduled OVN debug job ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml	Adds a twice-monthly bare-metal HyperShift agent OVN egress-IP debug job with assisted provisioning, a wait step, deprovisioning, and a 20-hour timeout.
Deprovision the ipecho service ci-operator/step-registry/hypershift/agent/ovn/ipecho/deprovision/*	Adds cleanup configuration and a script that stops and removes the service and files, reloads systemd, and absorbs cleanup errors.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ScheduledJob
  participant ProvisionStep
  participant DevScriptsHost
  participant IPEchoService
  participant WaitStep
  participant DeprovisionStep

  ScheduledJob->>ProvisionStep: Start ipecho provisioning
  ProvisionStep->>DevScriptsHost: Install and configure service
  DevScriptsHost->>IPEchoService: Start systemd service
  ProvisionStep->>IPEchoService: Check readiness
  IPEchoService-->>ProvisionStep: Return source IP
  ScheduledJob->>WaitStep: Run wait test
  ScheduledJob->>DeprovisionStep: Start cleanup
  DeprovisionStep->>DevScriptsHost: Stop and remove service

Loading

Possibly related PRs

• openshift/release#83038: Adds related HyperShift OVN ipecho lifecycle steps for AWS.

Suggested labels: rehearsals-ack

Suggested reviewers: jparrill, memodi

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
No-Sensitive-Data-In-Logs	❌ Error	The provision step logs caller source IPs through the HTTP handler/journal and prints the internal bridge IP and URL via curl and echo.	Suppress or mask source and bridge IPs in CI stdout and journal diagnostics; keep unmasked values only in protected step artifacts required by the test.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the new bare-metal HyperShift agent workflow and IP echo server added by the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds CI YAML, shell scripts, metadata, and OWNERS files; searches found no Ginkgo title constructs or dynamic test names.
Test Structure And Quality	✅ Passed	The PR changes only CI YAML, shell scripts, metadata, and OWNERS files; no Ginkgo test code or It/Eventually/BeforeEach constructs are present to review.
Microshift Test Compatibility	✅ Passed	The PR adds CI configuration and ipecho step scripts only; no new Ginkgo test declarations were found, and the job invokes the existing wait step.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds CI YAML, OWNERS, and shell provisioning steps only; it adds or modifies no Ginkgo e2e tests or It/Describe/Context/When bodies.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes CI job configuration and ipecho shell steps only; the full diff has no deployment/controller code or topology-sensitive scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes no Go or OTE suite code. The only print runs in a remote systemd ipecho service, while shell echoes are CI step logs, not openshift-tests JSON stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds CI YAML and shell helpers only; it invokes the existing generic wait step and adds no Ginkgo It, Describe, Context, or When test code.
No-Weak-Crypto	✅ Passed	The PR adds an HTTP IP-echo service and CI wiring only; added-line and source searches found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	Added Pod and step manifests contain no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, securityContext, or allowPrivilegeEscalation fields; root SSH only manages the documented host systemd se...

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asood-rh
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/openshift-tests-private/OWNERS [asood-rh]
• ci-operator/jobs/openshift/openshift-tests-private/OWNERS [asood-rh]
• ci-operator/step-registry/hypershift/agent/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[asood-rh]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug

[openshift-merge-bot]

@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[asood-rh]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug

[openshift-merge-bot]

@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

• astoycos
  • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • ci-operator/step-registry/hypershift/agent/ovn/OWNERS
  • ci-operator/step-registry/hypershift/agent/ovn/ipecho/OWNERS
  • ci-operator/step-registry/hypershift/agent/ovn/ipecho/deprovision/OWNERS
  • ci-operator/step-registry/hypershift/agent/ovn/ipecho/provision/OWNERS

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@asood-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[asood-rh]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug

[openshift-merge-bot]

@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@asood-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug	7000c1d	link	unknown	/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.