cnv-must-gather: add promtool backfill validation to test-incident CI step - #83036
cnv-must-gather: add promtool backfill validation to test-incident CI step#83036tiraboschi wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAzure and GCP incident tests now validate collected ChangesIncident metrics validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/kubevirt/must-gather/kubevirt-must-gather-main.yaml`:
- Around line 128-133: Add EXIT traps for cleanup in both validation blocks:
ci-operator/config/kubevirt/must-gather/kubevirt-must-gather-main.yaml lines
128-133 should clean the Azure temporary directories, and lines 274-279 should
clean the GCP temporary directories. Ensure cleanup runs on validation failure
as well as success, while retaining the existing successful-validation flow.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0a6b75f6-c61e-40a9-95e5-f6fbe117c458
📒 Files selected for processing (1)
ci-operator/config/kubevirt/must-gather/kubevirt-must-gather-main.yaml
029ff6f to
086c1d3
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@tiraboschi, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
086c1d3 to
9e6a6b5
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
… step Validate that the incident metrics file produced by --vm-incident is actually importable into Prometheus. Extract promtool from the cluster's own monitoring stack image and run tsdb create-blocks-from openmetrics against the collected incident-metrics.txt. Fails the CI step if the OpenMetrics format is invalid (e.g. duplicate labels, malformed lines). Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
9e6a6b5 to
3963076
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@tiraboschi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse |
|
@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 participant
Validate that the incident metrics file produced by --vm-incident is actually importable into Prometheus. Extract promtool from the cluster's own monitoring stack image and run tsdb create-blocks-from openmetrics against the collected incident-metrics.txt. Fails the CI step if the OpenMetrics format is invalid (e.g. duplicate labels, malformed lines).
Summary by CodeRabbit
cnv-must-gatherincident CI tests.promtoolfrom the cluster monitoring stack image.incident-metrics.txtwithtsdb create-blocks-from openmetrics.incident-metrics.txtis missing.