STOR-3001: Add TLS jobs for storage components under cluster storage operator - #83039
STOR-3001: Add TLS jobs for storage components under cluster storage operator#83039dfajmon wants to merge 1 commit into
Conversation
…operator AWS EBS AZURE DISK AZURE FILE GCP PD IBM VPC BLOCK CINDER MANILA POWERVS BLOCK VSPHERE VOLUME DATA SOURCE VALIDATOR
|
@dfajmon: This pull request references STOR-3001 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
WalkthroughThe change adds optional TLS 1.3 scanner jobs to four cluster-storage-operator CI configurations. The jobs cover cloud, virtualization, and storage validation workflows with platform-specific profiles, resources, namespaces, workflows, and test references. ChangesStorage operator TLS scanner coverage
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main.yaml`:
- Around line 225-348: Run make update to generate and commit the required
zz_generated_metadata and Prow job outputs for the structural CI jobs in
ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main.yaml:225-348,
openshift-cluster-storage-operator-release-4.23.yaml:225-348,
openshift-cluster-storage-operator-release-5.0.yaml:226-349, and
openshift-cluster-storage-operator-release-5.1.yaml:225-348; do not hand-edit
generated files.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2810462d-da08-4646-b14f-d0d43505c688
⛔ Files ignored due to path filters (4)
ci-operator/jobs/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.23-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.1-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main.yamlci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.23.yamlci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.0.yamlci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.1.yaml
| - always_run: false | ||
| as: tls-scanner-aws-ebs | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-aws | ||
| env: | ||
| SCAN_NAMESPACE: openshift-cluster-csi-drivers | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-aws | ||
| - always_run: false | ||
| as: tls-scanner-azure-disk-azure-file | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-azure | ||
| env: | ||
| SCAN_NAMESPACE: openshift-cluster-csi-drivers | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-azure | ||
| - always_run: false | ||
| as: tls-scanner-gcp-pd | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-gcp | ||
| env: | ||
| SCAN_NAMESPACE: openshift-cluster-csi-drivers | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-gcp | ||
| - always_run: false | ||
| as: tls-scanner-ibm-vpc-block | ||
| optional: true | ||
| steps: | ||
| cluster_profile: ibmcloud | ||
| env: | ||
| SCAN_NAMESPACE: openshift-cluster-csi-drivers | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-ibmcloud | ||
| - always_run: false | ||
| as: tls-scanner-openstack-cinder-manila | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openstack-vexxhost | ||
| env: | ||
| BASE_DOMAIN: shiftstack.devcluster.openshift.com | ||
| CONFIG_TYPE: minimal | ||
| SCAN_NAMESPACE: openshift-cluster-csi-drivers | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-openstack | ||
| - always_run: false | ||
| as: tls-scanner-powervs-block | ||
| optional: true | ||
| steps: | ||
| cluster_profile: powervs-6 | ||
| env: | ||
| ARCH: ppc64le | ||
| BRANCH: "5.0" | ||
| SCAN_NAMESPACE: openshift-cluster-csi-drivers | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-powervs | ||
| - always_run: false | ||
| as: tls-scanner-vsphere | ||
| optional: true | ||
| steps: | ||
| cluster_profile: vsphere-elastic | ||
| env: | ||
| SCAN_NAMESPACE: openshift-cluster-csi-drivers | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-vsphere | ||
| - always_run: false | ||
| as: tls-scanner-volumedatasourcevalidator | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-aws | ||
| env: | ||
| SCAN_NAMESPACE: openshift-cluster-storage-operator | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-aws |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Generate the CI job outputs.
These new as entries add structural CI jobs. The PR contains only source configurations. Run make update and commit the generated metadata and Prow job changes. Do not hand-edit generated files.
ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main.yaml#L225-L348: generate outputs for the main jobs.ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.23.yaml#L225-L348: generate outputs for the 4.23 jobs.ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.0.yaml#L226-L349: generate outputs for the 5.0 jobs.ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.1.yaml#L225-L348: generate outputs for the 5.1 jobs.
As per coding guidelines, “run make update after changes to regenerate zz_generated_metadata and Prow jobs.”
📍 Affects 4 files
ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main.yaml#L225-L348(this comment)ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.23.yaml#L225-L348ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.0.yaml#L226-L349ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-5.1.yaml#L225-L348
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main.yaml`
around lines 225 - 348, Run make update to generate and commit the required
zz_generated_metadata and Prow job outputs for the structural CI jobs in
ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-main.yaml:225-348,
openshift-cluster-storage-operator-release-4.23.yaml:225-348,
openshift-cluster-storage-operator-release-5.0.yaml:226-349, and
openshift-cluster-storage-operator-release-5.1.yaml:225-348; do not hand-edit
generated files.
Source: Coding guidelines
|
[REHEARSALNOTIFIER]
A total of 32 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfajmon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-cluster-storage-operator-main-tls-scanner-aws-ebs pull-ci-openshift-cluster-storage-operator-main-tls-scanner-azure-disk-azure-file pull-ci-openshift-cluster-storage-operator-main-tls-scanner-gcp-pd pull-ci-openshift-cluster-storage-operator-main-tls-scanner-ibm-vpc-block pull-ci-openshift-cluster-storage-operator-main-tls-scanner-openstack-cinder-manila pull-ci-openshift-cluster-storage-operator-main-tls-scanner-powervs-block pull-ci-openshift-cluster-storage-operator-main-tls-scanner-volumedatasourcevalidator pull-ci-openshift-cluster-storage-operator-main-tls-scanner-vsphere |
|
@dfajmon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dfajmon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 participants
AWS EBS
AZURE DISK
AZURE FILE
GCP PD
IBM VPC BLOCK
CINDER
MANILA
POWERVS BLOCK
VSPHERE
VOLUME DATA SOURCE VALIDATOR
Summary by CodeRabbit
This PR updates OpenShift CI configuration for the Cluster Storage Operator in releases 4.23, 5.0, 5.1, and
main.It adds optional TLS 1.3 scanner jobs for storage components on AWS, Azure, GCP, IBM VPC, OpenStack, PowerVS, and vSphere. It also adds a scanner job for
VolumeDataSourceValidator.Each job defines the required cluster profile, workflow, scanner resources, namespace, TLS adherence settings, and
tls-13/tls-scanner-runtest references.