use bot github credential in lint test - #83048
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe ROSA backend lint test now uses a temporary Git credential helper. The helper reads the GitHub OAuth token from the mounted credentials, replacing the previous OCM URL rewrite and OCM credential mount. ChangesROSA backend test credentials
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master.yaml`:
- Line 22: Remove the debug command cat /usr/local/github-credentials from the
test setup, or replace it with a non-sensitive readability check for
/usr/local/github-credentials/oauth; do not print any credential contents, and
preserve the subsequent make lint flow.
- Around line 30-31: Update the github-credentials volume reference in the
OpenShift CI configuration so it uses an existing CI secret matching the
/usr/local/github-credentials mount namespace, or change the CI commands and
mount_path to match the correct secret; do not treat github-credentials as a
user-specific github-credentials-${username} secret.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 488755c0-f748-41d5-b47e-933fc6c24af1
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master.yaml
|
/pj-rehearse |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master.yaml`:
- Around line 24-29: Update the OAuth file validation in the shell check to
require that /usr/local/github-credentials/oauth is both readable and non-empty,
not merely a regular file. Keep the existing error-and-exit behavior for invalid
files, and allow Git configuration to proceed only after this validation passes.
- Line 30: Replace the global URL rewrite in the OpenShift backend test
configuration with a Git credential helper that reads
`/usr/local/github-credentials/oauth` and supplies it as the HTTPS password
without embedding the token in Git URLs or config output. Preserve an
SSH-to-HTTPS rewrite only if this job requires handling `git@github.com:`
remotes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b6039a6f-97e7-42ec-a7da-fc93acd2dbb7
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master.yaml
|
/pj-rehearse |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master.yaml`:
- Around line 26-30: The credential helper in the get branch must be restricted
to GitHub HTTPS requests. Configure it as credential.https://github.com.helper,
validate both requested protocol and host before reading or emitting the OAuth
token, and exit silently for any other request.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f461efc5-d18b-4324-af08-955163b94a7d
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-backend-tests/openshift-online-rosa-backend-tests-master.yaml
|
@marcolan018: |
|
/pj-rehearse |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@marcolan018: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@marcolan018: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidleerh, marcolan018 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary by CodeRabbit
The ROSA backend lint test now uses the OpenShift CI bot's GitHub credential from the
github-credentials-openshift-ci-robot-private-git-clonersecret. The secret mounts at/usr/local/github-credentials, and a temporary Git credential helper supplies the credential to GitHub operations. The configuration removes the previous OCM credential and thenamespace: cifield.