chore(GCP-951): remove Atlantis integration status checks from gcp-hcp-infra

[floresroger]

Summary

• Remove atlantis-int/plan and atlantis-int/apply required status checks from main branch protection for openshift-online/gcp-hcp-infra
• Integration Terraform workspaces have been migrated from Atlantis to HCP Terraform (TFC), so these checks never report and block PRs from merging
• Stage checks (atlantis-stg/plan and atlantis-stg/apply) remain as that migration is pending

Test plan

• Verify make prow-config passes (no generated file changes expected since _prowconfig.yaml is applied directly)
• Confirm PRs to openshift-online/gcp-hcp-infra are no longer blocked by missing atlantis-int/* status checks after merge

JIRA: GCP-951

🤖 Generated with Claude Code

Summary by CodeRabbit

• Removes atlantis-int/plan and atlantis-int/apply from the required status checks for main in openshift-online/gcp-hcp-infra.
• Allows integration pull requests to merge after the Terraform workspaces migrated from Atlantis to HCP Terraform.
• Keeps atlantis-stg/plan and atlantis-stg/apply unchanged pending the stage migration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: bfb7b83a-c42e-436b-bfb9-c274110c5c60

📥 Commits

Reviewing files that changed from the base of the PR and between 658e1ba and c3b39ed.

📒 Files selected for processing (1)

• core-services/prow/02_config/openshift-online/gcp-hcp-infra/_prowconfig.yaml

💤 Files with no reviewable changes (1)

• core-services/prow/02_config/openshift-online/gcp-hcp-infra/_prowconfig.yaml

---

Walkthrough

The change removes atlantis-int/plan and atlantis-int/apply from the required status checks for the main branch. The atlantis-stg checks remain configured.

Changes

Branch protection configuration

Layer / File(s)	Summary
Required status checks core-services/prow/02_config/openshift-online/gcp-hcp-infra/_prowconfig.yaml	Removes the two atlantis-int checks from the main branch requirements. Keeps the atlantis-stg checks.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the removal of Atlantis integration status checks from gcp-hcp-infra.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only branch-protection YAML and adds no Ginkgo tests or test titles; the stability check is not applicable.
Test Structure And Quality	✅ Passed	The commit changes only one YAML file and contains no Ginkgo test code, so the Test Structure and Quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The pull request changes only a Prow YAML file and adds no Ginkgo e2e tests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only two YAML status-check lines; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The only change is branch protection in _prowconfig.yaml; no deployment manifests, operators, controllers, or scheduling constraints were modified.
Ote Binary Stdout Contract	✅ Passed	The PR changes only two YAML status-check entries; it adds or modifies no OTE binary or process-level code, so it introduces no stdout contract violation.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only Prow YAML and adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR changes only two Atlantis status-check entries in one YAML file; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparison code is added.
Container-Privileges	✅ Passed	The PR changes only a Prow branch-protection YAML file and removes two status checks; it adds no container or Kubernetes privilege settings.
No-Sensitive-Data-In-Logs	✅ Passed	The commit only removes two Atlantis status-check entries from YAML; it adds no logging code or sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@floresroger: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floresroger, patjlm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/openshift-online/gcp-hcp-infra/OWNERS [floresroger,patjlm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@floresroger: Updated the following 2 configmaps:

• config configmap in namespace ci at cluster app.ci using the following files:
  • key core-services-prow-02_config-openshift-online-gcp-hcp-infra-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/gcp-hcp-infra/_prowconfig.yaml
• config configmap in namespace ci at cluster core-ci using the following files:
  • key core-services-prow-02_config-openshift-online-gcp-hcp-infra-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/gcp-hcp-infra/_prowconfig.yaml

Details

In response to this:

Summary

• Remove atlantis-int/plan and atlantis-int/apply required status checks from main branch protection for openshift-online/gcp-hcp-infra
• Integration Terraform workspaces have been migrated from Atlantis to HCP Terraform (TFC), so these checks never report and block PRs from merging
• Stage checks (atlantis-stg/plan and atlantis-stg/apply) remain as that migration is pending

Test plan

• Verify make prow-config passes (no generated file changes expected since _prowconfig.yaml is applied directly)
• Confirm PRs to openshift-online/gcp-hcp-infra are no longer blocked by missing atlantis-int/* status checks after merge

JIRA: GCP-951

🤖 Generated with Claude Code

Summary by CodeRabbit

• Removes atlantis-int/plan and atlantis-int/apply from the required status checks for main in openshift-online/gcp-hcp-infra.
• Allows integration pull requests to merge after the Terraform workspaces migrated from Atlantis to HCP Terraform.
• Keeps atlantis-stg/plan and atlantis-stg/apply unchanged pending the stage migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.