Add Prow CI config for openshift-online/kube-applier-gcp by cristianoveiga · Pull Request #83071 · openshift/release

cristianoveiga · 2026-08-06T21:42:23Z

Summary

Register openshift-online/kube-applier-gcp in openshift/release with Prow CI for PR presubmit checks
ci-operator config with Go 1.26 builder and single make test entry point
Prow/Tide branch protection requiring ci/prow/test on main
Standard plugin config (approve, lgtm, external plugins) matching team conventions (gecko pattern)

Jira: GCP-983

Test plan

CI on this PR validates the config files (ci-operator-config, prow-config sanitization)
After merge, verify ci/prow/test triggers on PRs to openshift-online/kube-applier-gcp
Verify Tide is configured and branch protection is active on main

🤖 Generated with Claude Code

Summary by CodeRabbit

Adds OpenShift CI support for openshift-online/kube-applier-gcp.
Configures Go 1.26 presubmit jobs that run make test.
Adds standard approval, LGTM, Tide, and external plugin settings.
Registers repository approvers and reviewers.

- Register openshift-online/kube-applier-gcp in openshift/release - ci-operator config with Go 1.26 builder and make test presubmit - Prow/Tide branch protection requiring ci/prow/test on main - Standard plugin config matching team conventions (gecko pattern) Jira: GCP-983 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

openshift-ci · 2026-08-06T21:42:27Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-08-06T21:43:30Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2976eb02-c16f-4549-a97b-60e1d431be5e

📥 Commits

Reviewing files that changed from the base of the PR and between 8d9644d and af88364.

📒 Files selected for processing (1)

core-services/prow/02_config/openshift-online/kube-applier-gcp/_prowconfig.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

core-services/prow/02_config/openshift-online/kube-applier-gcp/_prowconfig.yaml

Walkthrough

This change onboards openshift-online/kube-applier-gcp with ownership metadata, main-branch CI configuration, repository-specific Prow plugins, and Tide merge criteria.

Changes

Repository onboarding

Layer / File(s)	Summary
CI validation and ownership `ci-operator/config/openshift-online/kube-applier-gcp/OWNERS`, `ci-operator/config/openshift-online/kube-applier-gcp/openshift-online-kube-applier-gcp-main.yaml`	Adds generated approver and reviewer lists. Adds the main-branch CI configuration with a RHEL 9 Go 1.26 builder, resource settings, and `make test`.
Prow policies and merge criteria `core-services/prow/02_config/openshift-online/kube-applier-gcp/OWNERS`, `core-services/prow/02_config/openshift-online/kube-applier-gcp/_pluginconfig.yaml`, `core-services/prow/02_config/openshift-online/kube-applier-gcp/_prowconfig.yaml`	Adds generated ownership metadata, repository-specific plugin settings, trusted trigger configuration, and Tide criteria requiring `approved` and `lgtm` labels while excluding blocking labels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

openshift/release#82930: Both add OWNERS approver and reviewer configurations for GCP-related CI components.

Suggested labels: rehearsals-ack

Suggested reviewers: jimdaga, jmguzik, prucek

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: adding Prow CI configuration for the specified repository.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The aggregate PR adds only YAML/OWNERS configuration; no Ginkgo source, test declarations, or dynamic test titles are present. The configured test name is the static `test`.
Test Structure And Quality	✅ Passed	The PR changes only OWNERS and YAML configuration files; no Ginkgo test code or Ginkgo/Gomega references are present, so these test-quality requirements do not apply.
Microshift Test Compatibility	✅ Passed	The PR adds only OWNERS and YAML CI/Prow configuration; the full diff contains no new Ginkgo declarations or MicroShift-sensitive test code.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request adds only CI/Prow YAML, OWNERS, and generated job metadata; the full diff adds no Ginkgo tests or multi-node test assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR adds only CI/Prow YAML and OWNERS files; no deployment manifests, controllers, replicas, affinities, topology spread, node selectors, tolerations, or PDBs were added.
Ote Binary Stdout Contract	✅ Passed	The PR adds only YAML/OWNERS and a generated Prow job; it adds no Go/OTE binary source or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds only CI/Prow YAML and OWNERS files; it adds no Ginkgo tests, IPv4 assumptions, or external network operations.
No-Weak-Crypto	✅ Passed	All PR-added configuration and generated job files contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	All five changed files contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, securityContext, or capability settings.
No-Sensitive-Data-In-Logs	✅ Passed	The inspected PR paths contain only YAML/OWNERS configuration; scans found no logging constructs, credential-bearing URLs, secret fields, or sensitive data values.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

cristianoveiga · 2026-08-06T21:46:17Z

/pj-rehearse pull-ci-openshift-online-kube-applier-gcp-main-test

openshift-merge-bot · 2026-08-06T21:46:20Z

@cristianoveiga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

cristianoveiga · 2026-08-06T22:06:34Z

/pj-rehearse ack

openshift-merge-bot · 2026-08-06T22:06:36Z

@cristianoveiga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

cristianoveiga · 2026-08-06T22:07:32Z

/cc @cblecker @jimdaga

cblecker · 2026-08-06T22:43:00Z

+branch-protection:
+  orgs:
+    openshift-online:
+      repos:
+        kube-applier-gcp:
+          branches:
+            main:
+              protect: true
+              required_status_checks:
+                contexts:
+                - ci/prow/test
+          restrictions:
+            teams:
+            - openshift-bots


We can drop all this. This will be covered by default.

TIL... thanks for the hint.

Most of our repos still have the branch protection block, though. We might want to clean up for consistency.

The other repos have non-prow contexts we need to teach prow about. You don't need it when it's prow's own context

cblecker · 2026-08-06T22:43:16Z

@@ -0,0 +1,81 @@
+approve:


We need an OWNERS file in this directory

- Drop explicit branch-protection section (covered by global protect-tested-repos: true) - Add OWNERS to core-services/prow/02_config/openshift-online/kube-applier-gcp/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-08-07T02:53:42Z

[REHEARSALNOTIFIER]
@cristianoveiga: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-online-kube-applier-gcp-main-test	openshift-online/kube-applier-gcp	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

cristianoveiga · 2026-08-07T03:00:45Z

/pj-rehearse pull-ci-openshift-online-kube-applier-gcp-main-test

openshift-merge-bot · 2026-08-07T03:00:48Z

@cristianoveiga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-08-07T03:12:38Z

@cristianoveiga: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cblecker · 2026-08-07T05:29:25Z

/lgtm
/approve

openshift-ci · 2026-08-07T05:29:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cristianoveiga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cblecker · 2026-08-07T07:03:51Z

/pj-rehearse ack

openshift-merge-bot · 2026-08-07T07:03:54Z

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-08-07T07:23:11Z

@cristianoveiga: Updated the following 2 configmaps:

config configmap in namespace ci at cluster app.ci using the following files:
- key core-services-prow-02_config-openshift-online-kube-applier-gcp-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/kube-applier-gcp/_prowconfig.yaml
config configmap in namespace ci at cluster core-ci using the following files:
- key core-services-prow-02_config-openshift-online-kube-applier-gcp-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/kube-applier-gcp/_prowconfig.yaml

Details

In response to this:

Summary

Register openshift-online/kube-applier-gcp in openshift/release with Prow CI for PR presubmit checks

ci-operator config with Go 1.26 builder and single make test entry point

Prow/Tide branch protection requiring ci/prow/test on main

Standard plugin config (approve, lgtm, external plugins) matching team conventions (gecko pattern)

Jira: GCP-983

Test plan

CI on this PR validates the config files (ci-operator-config, prow-config sanitization)

After merge, verify ci/prow/test triggers on PRs to openshift-online/kube-applier-gcp

Verify Tide is configured and branch protection is active on main

🤖 Generated with Claude Code

Summary by CodeRabbit

Adds OpenShift CI support for openshift-online/kube-applier-gcp.

Configures Go 1.26 presubmit jobs that run make test.

Adds standard approval, LGTM, Tide, and external plugin settings.

Registers repository approvers and reviewers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2026

cristianoveiga marked this pull request as ready for review August 6, 2026 21:58

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2026

openshift-ci Bot requested review from Prucek and jmguzik August 6, 2026 21:58

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 6, 2026

openshift-ci Bot requested review from cblecker and jimdaga August 6, 2026 22:07

cblecker suggested changes Aug 6, 2026

View reviewed changes

openshift-ci Bot assigned cblecker Aug 6, 2026

openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 7, 2026

fixup: regenerate _prowconfig.yaml via make prow-config

af88364

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 7, 2026

openshift-merge-bot Bot merged commit 1c336fa into openshift:main Aug 7, 2026
21 checks passed

Uh oh!

Conversation

cristianoveiga commented Aug 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Aug 6, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

cristianoveiga commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

cristianoveiga commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

cristianoveiga commented Aug 6, 2026

Uh oh!

cblecker Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

cristianoveiga Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

cblecker Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

cblecker Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

cristianoveiga Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Aug 7, 2026

Uh oh!

cristianoveiga commented Aug 7, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 7, 2026

Uh oh!

openshift-ci Bot commented Aug 7, 2026

Uh oh!

cblecker commented Aug 7, 2026

Uh oh!

openshift-ci Bot commented Aug 7, 2026

Uh oh!

cblecker commented Aug 7, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 7, 2026

Uh oh!

Uh oh!

openshift-ci Bot commented Aug 7, 2026

Summary

Test plan

Summary by CodeRabbit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cristianoveiga commented Aug 6, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 6, 2026 •

edited

Loading