refactor: remove socket.io

packages/server/package.json

@@ -26,8 +26,7 @@
     "markdown-it": "^12.3.2",
     "mongodb": "6.1.0",
     "node-fetch": "^3.3.0",
-    "pluralize": "^8.0.0",
-    "socket.io": "^4.8.3"
+    "pluralize": "^8.0.0"
   },
   "devDependencies": {
     "@types/koa-router": "^7.4.1"

packages/server/src/websocket/overview/v2.js → packages/server/src/features/overview/calcOverview.js

@@ -8,10 +8,8 @@ const {
   getOutputTransferCollection,
   getReferendaReferendumCollection,
   getChildBountyCollection,
+  getSubsquareTreasurySpendCollection,
 } = require("../../mongo");
-const { setOverviewV2, getOverviewV2 } = require("./../store");
-const { overviewRoomV2, OVERVIEW_FEED_INTERVAL } = require("../constants");
-const util = require("util");
 const { calcBestTipProposers } = require("./common/calcBestTipProposers");
 const {
   calcBestProposalBeneficiary,
@@ -20,26 +18,6 @@ const { getLatestSymbolPrice } = require("./common/getLatestSymbolPrice");
 const { calcToBeAwarded } = require("./common/calcToBeAwarded");
 const { calcOutput } = require("./common/calcOutput");
 const { calcCount } = require("./common/calcCount");
-const { getSubsquareTreasurySpendCollection } = require("../../mongo");
-
-async function feedOverviewV2(io) {
-  try {
-    const oldStoreOverview = getOverviewV2();
-    const overview = await calcOverview();
-
-    if (util.isDeepStrictEqual(overview, oldStoreOverview)) {
-      return;
-    }
-
-    setOverviewV2(overview);
-
-    io.to(overviewRoomV2).emit("overview", overview);
-  } catch (e) {
-    console.error("feed overview error:", e);
-  } finally {
-    setTimeout(feedOverviewV2.bind(null, io), OVERVIEW_FEED_INTERVAL);
-  }
-}
 
 async function calcOverview() {
   const proposalCol = await getProposalCollection();
@@ -161,6 +139,17 @@ async function calcOverview() {
   };
 }
 
-module.exports = {
-  feedOverviewV2,
-};
+const CACHE_TTL_MS = 30 * 1000;
+let cachedOverview = null;
+let cacheTimestamp = 0;
+
+async function getCachedOverview() {
+  const now = Date.now();
+  if (!cachedOverview || now - cacheTimestamp > CACHE_TTL_MS) {
+    cachedOverview = await calcOverview();
+    cacheTimestamp = now;
+  }
+  return cachedOverview;
+}
+
+module.exports = { calcOverview, getCachedOverview };

packages/server/src/features/overview/overview.controller.js

@@ -1,9 +1,8 @@
-const { getOverviewV2 } = require("../../websocket/store");
+const { getCachedOverview } = require("./calcOverview");
 
 async function getOverview(ctx) {
-  ctx.body = {
-    ...getOverviewV2(),
-  };
+  const overview = await getCachedOverview();
+  ctx.body = { ...overview };
 }
 
 module.exports = {

packages/server/src/features/stats/stats.controller.js

@@ -3,7 +3,7 @@ const {
   getInputWeeklyStatsCollection,
   getOutputWeeklyStatsCollection,
 } = require("../../mongo");
-const { getOverview } = require("../../websocket/store");
+const { getCachedOverview } = require("../overview/calcOverview");
 
 class StatsController {
   async getWeeklyStatsHistory(ctx) {
@@ -43,7 +43,7 @@ class StatsController {
   }
 
   async getTreasuryInOut(ctx) {
-    const overview = getOverview();
+    const overview = await getCachedOverview();
     if (!overview) {
       ctx.body = {};
       return;

packages/server/src/index.js

@@ -4,11 +4,9 @@ const Koa = require("koa");
 const bodyParser = require("koa-bodyparser");
 const logger = require("koa-logger");
 const helmet = require("koa-helmet");
-const http = require("http");
 const cors = require("@koa/cors");
 const { initDb } = require("./mongo");
 const { initDb: initAdminDb } = require("./mongo-admin");
-const { listenAndEmitInfo } = require("./websocket");
 
 const app = new Koa();
 
@@ -30,22 +28,13 @@ app.use(async (ctx, next) => {
 });
 
 require("./routes")(app);
-const server = http.createServer(app.callback());
-const io = require("socket.io")(server, {
-  cors: {
-    origin: "*",
-    methods: ["GET", "POST"],
-  },
-});
 
 Promise.all([initDb(), initAdminDb()])
   .then(async (db) => {
-    await listenAndEmitInfo(io);
-
     app.context.db = db;
     const port = process.env.PORT || 3213;
 
-    server.listen(port, () =>
+    app.listen(port, () =>
       console.log(`✅  The server is running at http://127.0.0.1:${port}/`),
     );
   })